From 5f23e02caa5ab128a4c01866dec91eaea8dc7cee Mon Sep 17 00:00:00 2001 From: jitendra007 Date: Thu, 18 Jun 2020 16:25:39 +0530 Subject: Fixed sonarcloud issues Issue-ID: CLI-270 Signed-off-by: jitendra007 Change-Id: Ibb52afb2fe8fe7c9be4299d1a1cb1e3d32ab0eca --- .../http/schema/OnapCommandSchemaHttpLoader.java | 16 +++++------ .../cli/fw/http/utils/OnapCommandHttpUtils.java | 6 ++-- .../schema/OnapCommandSchemaHttpLoaderTest.java | 32 ++++++++++++++++++++++ .../test/resources/sample-test-schema-http.yaml | 2 ++ 4 files changed, 45 insertions(+), 11 deletions(-) create mode 100644 profiles/http/src/test/java/org/onap/cli/fw/http/schema/OnapCommandSchemaHttpLoaderTest.java (limited to 'profiles/http/src') diff --git a/profiles/http/src/main/java/org/onap/cli/fw/http/schema/OnapCommandSchemaHttpLoader.java b/profiles/http/src/main/java/org/onap/cli/fw/http/schema/OnapCommandSchemaHttpLoader.java index d064547e..e7a643ad 100644 --- a/profiles/http/src/main/java/org/onap/cli/fw/http/schema/OnapCommandSchemaHttpLoader.java +++ b/profiles/http/src/main/java/org/onap/cli/fw/http/schema/OnapCommandSchemaHttpLoader.java @@ -68,8 +68,8 @@ public class OnapCommandSchemaHttpLoader { errors.addAll(OnapCommandSchemaLoader.parseSchema(cmd, defaultParameterMap, validateSchema)); } - Map>> commandYamlMap = - (Map>>) OnapCommandSchemaLoader.validateSchemaVersion(schemaName, cmd.getSchemaVersion()); + Map commandYamlMap = + OnapCommandSchemaLoader.validateSchemaVersion(schemaName, cmd.getSchemaVersion()); errors.addAll(parseHttpSchema(cmd, commandYamlMap, validateSchema)); @@ -162,20 +162,18 @@ public class OnapCommandSchemaHttpLoader { Map context = (Map) map.get(key2); for (String key: context.keySet()) { - switch (key) { - case OnapCommandHttpConstants.CONTEXT_REMOVE_EMPTY_JSON_NODES: + if (OnapCommandHttpConstants.CONTEXT_REMOVE_EMPTY_JSON_NODES.equals(key)) { Boolean flag = Boolean.valueOf(context.get(OnapCommandHttpConstants.CONTEXT_REMOVE_EMPTY_JSON_NODES).toString()); cmd.getInput().getContext().put(OnapCommandHttpConstants.CONTEXT_REMOVE_EMPTY_JSON_NODES, flag.toString()); - break; } } - break; case OnapCommandHttpConstants.MULTIPART_ENTITY_NAME: Object multipartEntityName = map.get(key2); cmd.getInput().setMultipartEntityName(multipartEntityName.toString()); break; + default : // Do nothing } }catch (Exception ex) { OnapCommandUtils.throwOrCollect(new OnapCommandInvalidSchema(cmd.getSchemaName(), ex), errorList, validate); @@ -235,6 +233,7 @@ public class OnapCommandSchemaHttpLoader { Object mode = serviceMap.get(key); srv.setMode(mode.toString()); break; + default : // Do nothing } } @@ -260,6 +259,7 @@ public class OnapCommandSchemaHttpLoader { case OnapCommandHttpConstants.SAMPLE_RESPONSE: // (mrkanag) implement sample response handling break; + default : // Do nothing } } } @@ -353,10 +353,8 @@ public class OnapCommandSchemaHttpLoader { for (Object successCode : requestSuccessCodes) { Integer code = Integer.valueOf(String.valueOf(successCode)); - if (code < 200 || code >= 300) { - if ( code != 404) { + if ((code < 200 || code >= 300) && code != 404) { errorList.add(OnapCommandHttpConstants.HTTP_SUCCESS_CODE_INVALID); - } } } diff --git a/profiles/http/src/main/java/org/onap/cli/fw/http/utils/OnapCommandHttpUtils.java b/profiles/http/src/main/java/org/onap/cli/fw/http/utils/OnapCommandHttpUtils.java index ec2f572a..dcc3082d 100644 --- a/profiles/http/src/main/java/org/onap/cli/fw/http/utils/OnapCommandHttpUtils.java +++ b/profiles/http/src/main/java/org/onap/cli/fw/http/utils/OnapCommandHttpUtils.java @@ -52,9 +52,11 @@ import net.minidev.json.JSONArray; public class OnapCommandHttpUtils { - static Logger LOG = LoggerFactory.getLogger(OnapCommandHttpUtils.class); + static Logger log = LoggerFactory.getLogger(OnapCommandHttpUtils.class); private static Gson gson = new GsonBuilder().serializeNulls().create(); - + private OnapCommandHttpUtils() { + throw new IllegalStateException("Utility class"); + } /** * Set argument to param value. * diff --git a/profiles/http/src/test/java/org/onap/cli/fw/http/schema/OnapCommandSchemaHttpLoaderTest.java b/profiles/http/src/test/java/org/onap/cli/fw/http/schema/OnapCommandSchemaHttpLoaderTest.java new file mode 100644 index 00000000..a6fbe9ab --- /dev/null +++ b/profiles/http/src/test/java/org/onap/cli/fw/http/schema/OnapCommandSchemaHttpLoaderTest.java @@ -0,0 +1,32 @@ +/* + * Copyright 2020 Huawei Technologies Co., Ltd. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.onap.cli.fw.http.schema; + +import org.junit.Test; + +import java.util.ArrayList; +import java.util.List; + +public class OnapCommandSchemaHttpLoaderTest { + @Test + public void validateHttpSccessCodesTest(){ + List errorList= new ArrayList<>(); + List requestSuccessCodes=new ArrayList<>(); + requestSuccessCodes.add("101"); + OnapCommandSchemaHttpLoader.validateHttpSccessCodes(errorList,requestSuccessCodes); + } +} diff --git a/profiles/http/src/test/resources/sample-test-schema-http.yaml b/profiles/http/src/test/resources/sample-test-schema-http.yaml index c78dcea4..ad25c155 100644 --- a/profiles/http/src/test/resources/sample-test-schema-http.yaml +++ b/profiles/http/src/test/resources/sample-test-schema-http.yaml @@ -89,6 +89,8 @@ http: method: POST body: '{"serviceName":"${service-name}","version":"${service-version}","url":"${service-url}","protocol":"REST","visualRange":"1","lb_policy":"hash","nodes":[{"ip":"${node-ip}","port":"${node-port}","ttl":0}]}' headers: + context: + remove_empty_node: true queries: createOrUpdate: ${create-or-update} success_codes: -- cgit 1.2.3-korg