From 3903891dfe8f9e2488fc9d1bd0858fa4670cff0e Mon Sep 17 00:00:00 2001 From: Kanagaraj Manickam k00365106 Date: Wed, 21 Feb 2018 10:27:26 +0530 Subject: Throw error when SNMP command failed Issue-ID: CLI-92 Change-Id: Ib6da4a647ea9cd25dd5e156cd58f4c21299efb9e Signed-off-by: Kanagaraj Manickam k00365106 --- .../org/onap/cli/fw/snmp/cmd/OnapSnmpCommand.java | 27 +++++++++++++--------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/profiles/snmp/src/main/java/org/onap/cli/fw/snmp/cmd/OnapSnmpCommand.java b/profiles/snmp/src/main/java/org/onap/cli/fw/snmp/cmd/OnapSnmpCommand.java index 6bdc9a03..1ee1b200 100644 --- a/profiles/snmp/src/main/java/org/onap/cli/fw/snmp/cmd/OnapSnmpCommand.java +++ b/profiles/snmp/src/main/java/org/onap/cli/fw/snmp/cmd/OnapSnmpCommand.java @@ -120,18 +120,23 @@ public class OnapSnmpCommand extends OnapCommand { case OnapCommandSnmpConstants.SNMP_CMD_GET: ResponseEvent responseEvent = snmp.send(getPDU(PDU.GET, oidStrArr), getTarget(), null); - if ( responseEvent != null && responseEvent.getResponse().getErrorStatus() == PDU.noError) { - Vector variableBindings = responseEvent.getResponse().getVariableBindings(); - variableBindings.stream().forEach(varBinding -> { //NOSONAR - String key = getKeyForValue(varBinding.getOid().toString()); - if (key != null) { - this.getResult().getRecordsMap().get(key).getValues().add( - varBinding.getVariable().toString()); - } - }); - } else { - throw new OnapSnmpErrorResponse("Error response from SNMP agent", + if ( responseEvent != null) { + if (responseEvent.getResponse().getErrorStatus() == PDU.noError) { + Vector variableBindings = responseEvent. + getResponse().getVariableBindings(); + variableBindings.stream().forEach(varBinding -> { //NOSONAR + String key = getKeyForValue(varBinding.getOid().toString()); + if (key != null) { + this.getResult().getRecordsMap().get(key).getValues().add( + varBinding.getVariable().toString()); + } + }); + } else { + throw new OnapSnmpErrorResponse("Error response from SNMP agent", responseEvent.getResponse().getErrorStatus()); + } + } else { + throw new OnapSnmpErrorResponse("Failed to send SNMP GET command"); } break; -- cgit 1.2.3-korg