Throw error when SNMP command failed

Issue-ID: CLI-92

Change-Id: Ib6da4a647ea9cd25dd5e156cd58f4c21299efb9e
Signed-off-by: Kanagaraj Manickam k00365106 <kanagaraj.manickam@huawei.com>

1 files changed, 16 insertions, 11 deletions

diff --git a/profiles/snmp/src/main/java/org/onap/cli/fw/snmp/cmd/OnapSnmpCommand.java b/profiles/snmp/src/main/java/org/onap/cli/fw/snmp/cmd/OnapSnmpCommand.java
index 6bdc9a03..1ee1b200 100644
--- a/profiles/snmp/src/main/java/org/onap/cli/fw/snmp/cmd/OnapSnmpCommand.java
+++ b/profiles/snmp/src/main/java/org/onap/cli/fw/snmp/cmd/OnapSnmpCommand.java
@@ -120,18 +120,23 @@ public class OnapSnmpCommand extends OnapCommand {
 
                 case OnapCommandSnmpConstants.SNMP_CMD_GET:
                     ResponseEvent responseEvent = snmp.send(getPDU(PDU.GET, oidStrArr), getTarget(), null);
-                    if ( responseEvent != null && responseEvent.getResponse().getErrorStatus() == PDU.noError) {
-                        Vector<? extends VariableBinding> variableBindings = responseEvent.getResponse().getVariableBindings();
-                        variableBindings.stream().forEach(varBinding -> { //NOSONAR
-                            String key = getKeyForValue(varBinding.getOid().toString());
-                            if (key != null) {
-                                this.getResult().getRecordsMap().get(key).getValues().add(
-                                        varBinding.getVariable().toString());
-                            }
-                        });
-                    } else {
-                        throw new OnapSnmpErrorResponse("Error response from SNMP agent",
+                    if ( responseEvent != null) {
+                        if (responseEvent.getResponse().getErrorStatus() == PDU.noError) {
+                            Vector<? extends VariableBinding> variableBindings = responseEvent.
+                                    getResponse().getVariableBindings();
+                            variableBindings.stream().forEach(varBinding -> { //NOSONAR
+                                String key = getKeyForValue(varBinding.getOid().toString());
+                                if (key != null) {
+                                    this.getResult().getRecordsMap().get(key).getValues().add(
+                                            varBinding.getVariable().toString());
+                                }
+                            });
+                        } else {
+                            throw new OnapSnmpErrorResponse("Error response from SNMP agent",
                                 responseEvent.getResponse().getErrorStatus());
+                        }
+                    } else {
+                        throw new OnapSnmpErrorResponse("Failed to send SNMP GET command");
                     }
                     break;