From aa486be66b1c29ad2e953cb44d105ca1bde40b1c Mon Sep 17 00:00:00 2001 From: sebdet Date: Tue, 18 Feb 2020 02:00:11 -0800 Subject: Modify the Ui Modify the Ui to have a modify option in the menu so that the user can tune the loop instance Issue-ID: CLAMP-648 Change-Id: I57523bc1c3afaf5ca5a2acf5c59823df06fd4cd9 Signed-off-by: sebdet --- ui-react/src/LoopUI.js | 3 + ui-react/src/__snapshots__/LoopUI.test.js.snap | 4 + ui-react/src/__snapshots__/OnapClamp.test.js.snap | 4 + ui-react/src/api/LoopService.js | 23 ++ ui-react/src/api/PolicyToscaService.js | 136 +++++++ ui-react/src/api/TemplateMenuService.js | 105 ------ ui-react/src/api/TemplateService.js | 41 ++ ui-react/src/api/example.json | 417 --------------------- .../src/components/dialogs/Loop/ModifyLoopModal.js | 187 +++++++++ .../src/components/dialogs/Loop/OpenLoopModal.js | 9 +- .../dialogs/Tosca/UploadToscaPolicyModal.js | 26 +- .../dialogs/Tosca/ViewLoopTemplatesModal.js | 4 +- .../dialogs/Tosca/ViewToscaPolicyModal.js | 10 +- .../UploadToscaPolicyModal.test.js.snap | 6 +- ui-react/src/components/menu/MenuBar.js | 37 +- .../menu/__snapshots__/MenuBar.test.js.snap | 117 ++++-- 16 files changed, 526 insertions(+), 603 deletions(-) create mode 100644 ui-react/src/api/PolicyToscaService.js delete mode 100644 ui-react/src/api/TemplateMenuService.js create mode 100644 ui-react/src/api/TemplateService.js delete mode 100644 ui-react/src/api/example.json create mode 100644 ui-react/src/components/dialogs/Loop/ModifyLoopModal.js (limited to 'ui-react/src') diff --git a/ui-react/src/LoopUI.js b/ui-react/src/LoopUI.js index b76f2640..7f07f343 100644 --- a/ui-react/src/LoopUI.js +++ b/ui-react/src/LoopUI.js @@ -38,6 +38,7 @@ import LoopActionService from './api/LoopActionService'; import { Route } from 'react-router-dom' import OpenLoopModal from './components/dialogs/Loop/OpenLoopModal'; +import ModifyLoopModal from './components/dialogs/Loop/ModifyLoopModal'; import OperationalPolicyModal from './components/dialogs/OperationalPolicy/OperationalPolicyModal'; import ConfigurationPolicyModal from './components/dialogs/ConfigurationPolicy/ConfigurationPolicyModal'; import LoopPropertiesModal from './components/dialogs/Loop/LoopPropertiesModal'; @@ -257,6 +258,8 @@ export default class LoopUI extends React.Component { ()} /> ()} /> ()} /> + ()} /> + ()} /> ()} /> diff --git a/ui-react/src/__snapshots__/LoopUI.test.js.snap b/ui-react/src/__snapshots__/LoopUI.test.js.snap index 98f1a460..98f802df 100644 --- a/ui-react/src/__snapshots__/LoopUI.test.js.snap +++ b/ui-react/src/__snapshots__/LoopUI.test.js.snap @@ -32,6 +32,10 @@ exports[`Verify LoopUI Test the render method 1`] = ` path="/loopProperties" render={[Function]} /> + + props.theme.toscaTextareaBackgroundColor}; + text-align: justify; + font-size: ${props => props.theme.toscaTextareaFontSize}; + width: 100%; + height: 300px; +` +const cellStyle = { border: '1px solid black' }; +const headerStyle = { backgroundColor: '#ddd', border: '2px solid black' }; +const rowHeaderStyle = {backgroundColor:'#ddd', fontSize: '15pt', text: 'bold', border: '1px solid black'}; + +export default class ModifyLoopModal extends React.Component { + + state = { + show: true, + loopCache: this.props.loopCache, + content: 'Please select Tosca model to view the details', + selectedRowData: {}, + toscaPolicyModelsData: [], + toscaColumns: [ + { title: "#", field: "index", render: rowData => rowData.tableData.id + 1, + cellStyle: cellStyle, + headerStyle: headerStyle + }, + { title: "Policy Model Type", field: "policyModelType", + cellStyle: cellStyle, + headerStyle: headerStyle + }, + { title: "Policy Acronym", field: "policyAcronym", + cellStyle: cellStyle, + headerStyle: headerStyle + }, + { title: "Version", field: "version", + cellStyle: cellStyle, + headerStyle: headerStyle + }, + { title: "Uploaded By", field: "updatedBy", + cellStyle: cellStyle, + headerStyle: headerStyle + }, + { title: "Uploaded Date", field: "updatedDate", editable: 'never', + cellStyle: cellStyle, + headerStyle: headerStyle + }, + { title: "Add", field: "updatedDate", editable: 'never', + cellStyle: cellStyle, + headerStyle: headerStyle + } + ], + tableIcons: { + FirstPage: forwardRef((props, ref) => ), + LastPage: forwardRef((props, ref) => ), + NextPage: forwardRef((props, ref) => ), + PreviousPage: forwardRef((props, ref) => ), + ResetSearch: forwardRef((props, ref) => ), + Search: forwardRef((props, ref) => ), + SortArrow: forwardRef((props, ref) => ) + } + }; + + constructor(props, context) { + super(props, context); + this.handleClose = this.handleClose.bind(this); + this.getPolicyToscaModels = this.getToscaPolicyModels.bind(this); + this.handleYamlContent = this.handleYamlContent.bind(this); + this.getToscaPolicyModelYaml = this.getToscaPolicyModelYaml.bind(this); + this.handleAdd = this.handleAdd.bind(this); + this.getToscaPolicyModels(); + } + + componentWillReceiveProps(newProps) { + this.setState({ + loopCache: newProps.loopCache, + temporaryPropertiesJson: JSON.parse(JSON.stringify(newProps.loopCache.getGlobalProperties())) + }); + } + + getToscaPolicyModels() { + PolicyToscaService.getToscaPolicyModels().then(allToscaModels => { + this.setState({ toscaPolicyModelsData: allToscaModels}); + }); + } + + getToscaPolicyModelYaml(policyModelType, policyModelVersion) { + if (typeof policyModelType !== "undefined") { + PolicyToscaService.getToscaPolicyModelYaml(policyModelType, policyModelVersion).then(toscaYaml => { + if (toscaYaml.length !== 0) { + this.setState({content: toscaYaml}) + } else { + this.setState({ content: 'No Tosca model Yaml available' }) + } + }); + } else { + this.setState({ content: 'Please select Tosca model to view the details' }) + } + } + + handleYamlContent(event) { + this.setState({ content: event.target.value }); + } + + handleClose() { + this.setState({ show: false }); + this.props.history.push('/'); + } + + handleAdd() { + LoopService.addOperationalPolicyType(this.state.loopCache.getLoopName(),this.state.selectedRowData.policyModelType,this.state.selectedRowData.version); + this.handleClose(); + this.props.loadLoopFunction(this.state.loopCache.getLoopName()); + } + + render() { + return ( + + + + + {this.getToscaPolicyModelYaml(rowData.policyModelType, rowData.version);this.setState({selectedRowData: rowData})}} + options={{ + headerStyle: rowHeaderStyle, + rowStyle: rowData => ({ + backgroundColor: (this.state.selectedRowData !== {} && this.state.selectedRowData.id === rowData.tableData.id) ? '#EEE' : '#FFF' + }) + }} + /> +
+ +
+
+ + + + +
+ ); + } +} diff --git a/ui-react/src/components/dialogs/Loop/OpenLoopModal.js b/ui-react/src/components/dialogs/Loop/OpenLoopModal.js index fbfc727e..4e8d9782 100644 --- a/ui-react/src/components/dialogs/Loop/OpenLoopModal.js +++ b/ui-react/src/components/dialogs/Loop/OpenLoopModal.js @@ -68,15 +68,16 @@ export default class OpenLoopModal extends React.Component { getLoopNames() { LoopService.getLoopNames().then(loopNames => { - const loopOptions = loopNames.map((loopName) => { return { label: loopName, value: loopName } }); - this.setState({ loopNames: loopOptions }) + if (Object.entries(loopNames).length !== 0) { + const loopOptions = loopNames.filter(loopName => loopName!=='undefined').map((loopName) => { return { label: loopName, value: loopName } }); + this.setState({ loopNames: loopOptions }) + } }); } handleOpen() { console.info("Loop " + this.state.chosenLoopName + " is chosen"); - this.setState({ show: false }); - this.props.history.push('/'); + this.handleClose(); this.props.loadLoopFunction(this.state.chosenLoopName); } diff --git a/ui-react/src/components/dialogs/Tosca/UploadToscaPolicyModal.js b/ui-react/src/components/dialogs/Tosca/UploadToscaPolicyModal.js index 76beca71..2e0460f6 100644 --- a/ui-react/src/components/dialogs/Tosca/UploadToscaPolicyModal.js +++ b/ui-react/src/components/dialogs/Tosca/UploadToscaPolicyModal.js @@ -28,7 +28,7 @@ import Row from 'react-bootstrap/Row'; import Col from 'react-bootstrap/Col'; import styled from 'styled-components'; import Alert from 'react-bootstrap/Alert'; -import TemplateMenuService from '../../../api/TemplateMenuService'; +import PolicyToscaService from '../../../api/PolicyToscaService'; const ModalStyled = styled(Modal)` background-color: transparent; @@ -37,7 +37,7 @@ export default class UploadToscaPolicyModal extends React.Component { constructor(props, context) { super(props, context); - this.handleUploadToscaPolicyModel = this.handleUploadToscaPolicyModel.bind(this); + this.handleCreateFromToscaPolicyModel = this.handleCreateFromToscaPolicyModel.bind(this); this.handleClose = this.handleClose.bind(this); this.handlePolicyModelType = this.handlePolicyModelType.bind(this); this.fileSelectedHandler = this.fileSelectedHandler.bind(this); @@ -55,16 +55,10 @@ export default class UploadToscaPolicyModal extends React.Component { fileSelectedHandler = (event) => { if (event.target.files && event.target.files[0]) { const scope = this; - let reader = new FileReader(); + let reader = new FileReader(); this.setState({policyModelType: '', policyModelTosca: '' }); reader.onload = function(e) { - var lines = reader.result.split('\n'); - for (var line = 0; line < lines.length; line++) { - if(lines[line].trim().slice(0, 24) === 'onap.policies.monitoring') { - var microsvc = lines[line].trim().slice(0, -1); - scope.setState({ policyModelType: microsvc, policyModelTosca: reader.result}); - } - } + scope.setState({ policyModelTosca: reader.result}); }; console.log("Filename is", event.target.files[0]); reader.readAsText(event.target.files[0]); @@ -77,11 +71,11 @@ export default class UploadToscaPolicyModal extends React.Component { this.props.history.push('/'); } - handleUploadToscaPolicyModel(e) { - e.preventDefault(); + handleCreateFromToscaPolicyModel(e) { + e.preventDefault(); console.log("Policy Model Type is", this.state.policyModelType); if(this.state.policyModelType && this.state.policyModelTosca) { - TemplateMenuService.uploadToscaPolicyModal(this.state.policyModelType, this.state.policyModelTosca).then(resp => { + PolicyToscaService.createPolicyModelFromToscaModel(this.state.policyModelType, this.state.policyModelTosca).then(resp => { if(resp.status === 200) { this.setState({apiResponseStatus: resp.status, apiResponseMessage: resp.message, upldBtnClicked: true}); } else { @@ -103,7 +97,7 @@ export default class UploadToscaPolicyModal extends React.Component { return ( - Upload Tosca Modal + Upload Tosca Model @@ -114,7 +108,7 @@ export default class UploadToscaPolicyModal extends React.Component {

{this.state.selectedFile.name}

- Micro Service Name: + Policy Model Type: {!this.state.apiResponseStatus?:""} - {!this.state.apiResponseStatus?:""} + {!this.state.apiResponseStatus?:""} {this.state.apiResponseStatus?

{this.state.apiResponseMessage}

diff --git a/ui-react/src/components/menu/MenuBar.js b/ui-react/src/components/menu/MenuBar.js index 98c7bffc..c1a7ac3b 100644 --- a/ui-react/src/components/menu/MenuBar.js +++ b/ui-react/src/components/menu/MenuBar.js @@ -87,27 +87,28 @@ export default class MenuBar extends React.Component { return ( - - Upload Tosca Policy Model - View Tosca Policy Models - View Loop Templates + + View All Templates - - Open CL - Properties CL - Close Model - - - Submit - Stop - Restart - Delete - Deploy - UnDeploy - - + + Upload Tosca Model + View Tosca Models + + + Open Loop + Properties + Close + Modify Refresh Status + + Create and deploy to Policy Engine(SUBMIT) + Undeploy from Policy Engine (STOP) + ReDeploy to Policy Engine (RESTART) + Delete loop instance (DELETE) + Deploy to DCAE (DEPLOY) + UnDeploy to DCAE (UNDEPLOY) + Wiki Contact Us diff --git a/ui-react/src/components/menu/__snapshots__/MenuBar.test.js.snap b/ui-react/src/components/menu/__snapshots__/MenuBar.test.js.snap index 14030f01..a7e66edd 100644 --- a/ui-react/src/components/menu/__snapshots__/MenuBar.test.js.snap +++ b/ui-react/src/components/menu/__snapshots__/MenuBar.test.js.snap @@ -3,7 +3,7 @@ exports[`Verify MenuBar Test the render method 1`] = ` - Upload Tosca Policy Model + View All Templates + + - View Tosca Policy Models + Upload Tosca Model - View Loop Templates + View Tosca Models - Open CL + Open Loop - Properties CL + Properties - Close Model + Close + + + Modify - - - Submit + Refresh Status + + - Stop + Create and deploy to Policy Engine(SUBMIT) - Restart + Undeploy from Policy Engine (STOP) - Delete + ReDeploy to Policy Engine (RESTART) - Deploy + Delete loop instance (DELETE) - UnDeploy + Deploy to DCAE (DEPLOY) - - - Refresh Status + UnDeploy to DCAE (UNDEPLOY)