From 0cfec3c5d53ed995e66f135ccd584d7ab0950258 Mon Sep 17 00:00:00 2001
From: Gabriel <adam.krysiak@nokia.com>
Date: Tue, 3 Jul 2018 10:30:01 +0200
Subject: Fix weakness causing NPE
Change-Id: I1f6bfa75990082dc411d813528702cc3cc140f5c
Issue-ID: CLAMP-193
Signed-off-by: Gabriel <adam.krysiak@nokia.com>
---
.../onap/clamp/clds/it/SdcCatalogServicesItCase.java | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
(limited to 'src/test/java/org/onap')
diff --git a/src/test/java/org/onap/clamp/clds/it/SdcCatalogServicesItCase.java b/src/test/java/org/onap/clamp/clds/it/SdcCatalogServicesItCase.java
index 4a13c62a..330ee605 100644
--- a/src/test/java/org/onap/clamp/clds/it/SdcCatalogServicesItCase.java
+++ b/src/test/java/org/onap/clamp/clds/it/SdcCatalogServicesItCase.java
@@ -17,14 +17,17 @@
* See the License for the specific language governing permissions and
* limitations under the License.
* ============LICENSE_END============================================
+ * Modifications copyright (c) 2018 Nokia
* ===================================================================
*
*/
package org.onap.clamp.clds.it;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.Assert.assertTrue;
+import java.util.ArrayList;
import java.util.LinkedList;
import java.util.List;
@@ -170,6 +173,23 @@ public class SdcCatalogServicesItCase {
assertTrue("1.0".equals(res2.getVersion()));
}
+
+ @Test
+ public void removeDuplicateSdcFunctionShouldNotReturnNull(){
+ // given
+ SdcCatalogServices catalogServices = new SdcCatalogServices();
+
+ // when
+ List<SdcResourceBasicInfo> firstResult = catalogServices
+ .removeDuplicateSdcResourceBasicInfo(null);
+ List<SdcResourceBasicInfo> secondResult = catalogServices
+ .removeDuplicateSdcResourceBasicInfo(new ArrayList<>());
+
+ // then
+ assertThat(firstResult).isEmpty();
+ assertThat(secondResult).isEmpty();
+ }
+
@Test
public void getServiceUuidFromServiceInvariantIdTest() throws Exception {
SdcCatalogServices spy = Mockito.spy(sdcCatalogWired);
--
cgit