From 84d012a83b2955f6a92cd79bbc1d5d6d5857ca8e Mon Sep 17 00:00:00 2001 From: "Determe, Sebastien (sd378r)" Date: Tue, 29 Aug 2017 04:43:14 -0700 Subject: Fix a potential NPE The code must verify if the policy has been found or not Change-Id: I41343aec40643c29180c892996e4a65d0805193e Issue-Id: CLAMP-43 Signed-off-by: Determe, Sebastien (sd378r) --- .../clds/client/OperationalPolicyDeleteDelegate.java | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) (limited to 'src/main/java/org') diff --git a/src/main/java/org/onap/clamp/clds/client/OperationalPolicyDeleteDelegate.java b/src/main/java/org/onap/clamp/clds/client/OperationalPolicyDeleteDelegate.java index e7b0be53..2c60941c 100644 --- a/src/main/java/org/onap/clamp/clds/client/OperationalPolicyDeleteDelegate.java +++ b/src/main/java/org/onap/clamp/clds/client/OperationalPolicyDeleteDelegate.java @@ -56,13 +56,15 @@ public class OperationalPolicyDeleteDelegate implements JavaDelegate { prop.setCurrentModelElementId(policy.getId()); String responseMessage = ""; - for (PolicyChain policyChain : policy.getPolicyChains()) { - prop.setPolicyUniqueId(policyChain.getPolicyId()); - responseMessage = policyClient.deleteBrms(prop); - } - if (responseMessage != null) { - execution.setVariable("operationalPolicyDeleteResponseMessage", responseMessage.getBytes()); - } + if(policy.isFound()){ + for (PolicyChain policyChain : policy.getPolicyChains()) { + prop.setPolicyUniqueId(policyChain.getPolicyId()); + responseMessage = policyClient.deleteBrms(prop); + } + if (responseMessage != null) { + execution.setVariable("operationalPolicyDeleteResponseMessage", responseMessage.getBytes()); + } + } } } -- cgit 1.2.3-korg