From 564fdb0c2e601df73813a4e9d080bd1666befce4 Mon Sep 17 00:00:00 2001 From: xuegao Date: Wed, 2 Oct 2019 11:18:10 +0200 Subject: Add react ui test Add react ui test to improve code coverage. Issue-ID: CLAMP-509 Change-Id: Ic9c974a78ee453dddb8f985f3e9c9067f66e95d9 Signed-off-by: xuegao --- .../ConfigurationPolicyModal.test.js | 18 ++--- ui-react/src/components/dialogs/DeployLoop.test.js | 65 ++++++++++++++++ .../src/components/dialogs/LoopProperties.test.js | 47 ++++++++++++ .../dialogs/OpenLoop/OpenLoopModal.test.js | 11 ++- .../OperationalPolicyModal.test.js | 23 +++--- .../src/components/dialogs/PerformActions.test.js | 88 ++++++++++++++++++++++ .../src/components/dialogs/RefreshStatus.test.js | 72 ++++++++++++++++++ ui-react/src/components/dialogs/UserInfo.test.js | 2 +- 8 files changed, 299 insertions(+), 27 deletions(-) create mode 100644 ui-react/src/components/dialogs/PerformActions.test.js create mode 100644 ui-react/src/components/dialogs/RefreshStatus.test.js diff --git a/ui-react/src/components/dialogs/ConfigurationPolicy/ConfigurationPolicyModal.test.js b/ui-react/src/components/dialogs/ConfigurationPolicy/ConfigurationPolicyModal.test.js index 934fa492..e0aa8c6b 100644 --- a/ui-react/src/components/dialogs/ConfigurationPolicy/ConfigurationPolicyModal.test.js +++ b/ui-react/src/components/dialogs/ConfigurationPolicy/ConfigurationPolicyModal.test.js @@ -29,13 +29,13 @@ import LoopCache from '../../../api/LoopCache'; describe('Verify DeployLoop', () => { beforeEach(() => { fetch.resetMocks(); - fetch.mockImplementation(() => { - return Promise.resolve({ - ok: true, - status: 200, - text: () => "OK" - }); - }); + fetch.mockImplementation(() => { + return Promise.resolve({ + ok: true, + status: 200, + text: () => "OK" + }); + }); }) const loopCache = new LoopCache({ "name": "LOOP_Jbv1z_v1_0_ResourceInstanceName1_tca", @@ -59,7 +59,7 @@ describe('Verify DeployLoop', () => { expect(handleClose).toHaveBeenCalledTimes(1); expect(component.state('show')).toEqual(false); - expect(historyMock.push.mock.calls[0]).toEqual([ '/', ]); + expect(historyMock.push.mock.calls[0]).toEqual([ '/']); }); it('Test handleSave', async () => { @@ -74,6 +74,6 @@ describe('Verify DeployLoop', () => { expect(handleSave).toHaveBeenCalledTimes(1); expect(component.state('show')).toEqual(false); expect(component.state('componentName')).toEqual("TCA_h2NMX_v1_0_ResourceInstanceName1_tca"); - expect(historyMock.push.mock.calls[0]).toEqual([ '/', ]); + expect(historyMock.push.mock.calls[0]).toEqual([ '/']); }); }); \ No newline at end of file diff --git a/ui-react/src/components/dialogs/DeployLoop.test.js b/ui-react/src/components/dialogs/DeployLoop.test.js index bb08baf1..2959ed65 100644 --- a/ui-react/src/components/dialogs/DeployLoop.test.js +++ b/ui-react/src/components/dialogs/DeployLoop.test.js @@ -24,6 +24,8 @@ import React from 'react'; import { shallow } from 'enzyme'; import DeployLoop from './DeployLoop'; import LoopCache from '../../api/LoopCache'; +import LoopActionService from '../../api/LoopActionService'; +import LoopService from '../../api/LoopService'; describe('Verify DeployLoop', () => { const loopCache = new LoopCache({ @@ -43,4 +45,67 @@ describe('Verify DeployLoop', () => { expect(component).toMatchSnapshot(); }); + + it('Test handleClose', () => { + const historyMock = { push: jest.fn() }; + const handleClose = jest.spyOn(DeployLoop.prototype,'handleClose'); + const component = shallow() + + component.find('[variant="secondary"]').prop('onClick')(); + + expect(handleClose).toHaveBeenCalledTimes(1); + expect(historyMock.push.mock.calls[0]).toEqual([ '/']); + }); + + it('Test handleSave successful', async () => { + const flushPromises = () => new Promise(setImmediate); + const historyMock = { push: jest.fn() }; + const updateLoopFunction = jest.fn(); + const handleSave = jest.spyOn(DeployLoop.prototype,'handleSave'); + LoopService.updateGlobalProperties = jest.fn().mockImplementation(() => { + return Promise.resolve({ + ok: true, + status: 200, + text: () => "OK" + }); + }); + LoopActionService.performAction = jest.fn().mockImplementation(() => { + return Promise.resolve({ + ok: true, + status: 200, + json: () => {} + }); + }); + LoopActionService.refreshStatus = jest.fn().mockImplementation(() => { + return Promise.resolve({ + ok: true, + status: 200, + json: () => {} + }); + }); + const jsdomAlert = window.alert; + window.alert = () => {}; + const component = shallow() + + component.find('[variant="primary"]').prop('onClick')(); + await flushPromises(); + component.update(); + + expect(handleSave).toHaveBeenCalledTimes(1); + expect(component.state('show')).toEqual(false); + expect(historyMock.push.mock.calls[0]).toEqual([ '/']); + window.alert = jsdomAlert; + handleSave.mockClear(); + }); + + it('Onchange event', () => { + const event = { target: { name: "location_id", value: "testLocation"} }; + const component = shallow(); + const forms = component.find('StateManager'); + + component.find('[name="location_id"]').simulate('change', event); + component.update(); + expect(component.state('temporaryPropertiesJson').dcaeDeployParameters.location_id).toEqual("testLocation"); + }); }); \ No newline at end of file diff --git a/ui-react/src/components/dialogs/LoopProperties.test.js b/ui-react/src/components/dialogs/LoopProperties.test.js index fadb9099..9b74fe76 100644 --- a/ui-react/src/components/dialogs/LoopProperties.test.js +++ b/ui-react/src/components/dialogs/LoopProperties.test.js @@ -24,6 +24,7 @@ import React from 'react'; import { shallow } from 'enzyme'; import LoopProperties from './LoopProperties'; import LoopCache from '../../api/LoopCache'; +import LoopService from '../../api/LoopService'; describe('Verify LoopProperties', () => { const loopCache = new LoopCache({ @@ -58,4 +59,50 @@ describe('Verify LoopProperties', () => { expect(component).toMatchSnapshot(); }); + + it('Test handleClose', () => { + const historyMock = { push: jest.fn() }; + const handleClose = jest.spyOn(LoopProperties.prototype,'handleClose'); + const component = shallow() + + component.find('[variant="secondary"]').prop('onClick')(); + + expect(handleClose).toHaveBeenCalledTimes(1); + expect(historyMock.push.mock.calls[0]).toEqual([ '/']); + }); + + it('Test handleSave successful', async () => { + const flushPromises = () => new Promise(setImmediate); + const historyMock = { push: jest.fn() }; + const loadLoopFunction = jest.fn(); + const handleSave = jest.spyOn(LoopProperties.prototype,'handleSave'); + LoopService.updateGlobalProperties = jest.fn().mockImplementation(() => { + return Promise.resolve({ + ok: true, + status: 200, + text: () => "OK" + }); + }); + + const component = shallow() + + component.find('[variant="primary"]').prop('onClick')(); + await flushPromises(); + component.update(); + + expect(handleSave).toHaveBeenCalledTimes(1); + expect(component.state('show')).toEqual(false); + expect(historyMock.push.mock.calls[0]).toEqual([ '/']); + }); + + it('Onchange event', () => { + const event = {target:{name:"dcaeDeployParameters", value:"{\"location_id\": \"testLocation\",\"policy_id\": \"TCA_h2NMX_v1_0_ResourceInstanceName1_tca\"}"}}; + const component = shallow(); + + component.find('FormControl').simulate('change', event); + component.update(); + + expect(component.state('temporaryPropertiesJson').dcaeDeployParameters.location_id).toEqual("testLocation"); + }); }); diff --git a/ui-react/src/components/dialogs/OpenLoop/OpenLoopModal.test.js b/ui-react/src/components/dialogs/OpenLoop/OpenLoopModal.test.js index 5153de95..208c947c 100644 --- a/ui-react/src/components/dialogs/OpenLoop/OpenLoopModal.test.js +++ b/ui-react/src/components/dialogs/OpenLoop/OpenLoopModal.test.js @@ -34,9 +34,9 @@ describe('Verify OpenLoopModal', () => { "LOOP_gmtAS_v1_0_ResourceInstanceName2_tca_2" ])); }) - + it('Test the render method', () => { - + const component = shallow(); expect(component).toMatchSnapshot(); }); @@ -44,7 +44,6 @@ describe('Verify OpenLoopModal', () => { it('Onchange event', () => { const event = {value: 'LOOP_gmtAS_v1_0_ResourceInstanceName1_tca_3'}; const component = shallow(); - const forms = component.find('StateManager'); component.find('StateManager').simulate('change', event); component.update(); @@ -60,7 +59,7 @@ describe('Verify OpenLoopModal', () => { expect(handleClose).toHaveBeenCalledTimes(1); expect(component.state('show')).toEqual(false); - expect(historyMock.push.mock.calls[0]).toEqual([ '/', ]); + expect(historyMock.push.mock.calls[0]).toEqual([ '/']); handleClose.mockClear(); }); @@ -75,8 +74,8 @@ describe('Verify OpenLoopModal', () => { expect(handleOpen).toHaveBeenCalledTimes(1); expect(component.state('show')).toEqual(false); - expect(historyMock.push.mock.calls[0]).toEqual([ '/', ]); - + expect(historyMock.push.mock.calls[0]).toEqual([ '/']); + handleOpen.mockClear(); }); diff --git a/ui-react/src/components/dialogs/OperationalPolicy/OperationalPolicyModal.test.js b/ui-react/src/components/dialogs/OperationalPolicy/OperationalPolicyModal.test.js index da60b671..9c7da310 100644 --- a/ui-react/src/components/dialogs/OperationalPolicy/OperationalPolicyModal.test.js +++ b/ui-react/src/components/dialogs/OperationalPolicy/OperationalPolicyModal.test.js @@ -28,13 +28,13 @@ import LoopCache from '../../../api/LoopCache'; describe('Verify OperationalPolicyModal', () => { beforeEach(() => { fetch.resetMocks(); - fetch.mockImplementation(() => { - return Promise.resolve({ - ok: true, - status: 200, - text: () => "OK" - }); - }); + fetch.mockImplementation(() => { + return Promise.resolve({ + ok: true, + status: 200, + text: () => "OK" + }); + }); }) const loopCache = new LoopCache({ "name": "LOOP_Jbv1z_v1_0_ResourceInstanceName1_tca", @@ -52,7 +52,7 @@ describe('Verify OperationalPolicyModal', () => { }); const historyMock = { push: jest.fn() }; const flushPromises = () => new Promise(setImmediate); - + it('Test handleClose', () => { const handleClose = jest.spyOn(OperationalPolicyModal.prototype,'handleClose'); const component = mount() @@ -61,13 +61,14 @@ describe('Verify OperationalPolicyModal', () => { expect(handleClose).toHaveBeenCalledTimes(1); expect(component.state('show')).toEqual(false); - expect(historyMock.push.mock.calls[0]).toEqual([ '/', ]); + expect(historyMock.push.mock.calls[0]).toEqual([ '/']); }); it('Test handleSave', async () => { const loadLoopFunction = jest.fn(); const handleSave = jest.spyOn(OperationalPolicyModal.prototype,'handleSave'); - const component = mount() + const component = mount() component.find('[variant="primary"]').prop('onClick')(); await flushPromises(); @@ -75,6 +76,6 @@ describe('Verify OperationalPolicyModal', () => { expect(handleSave).toHaveBeenCalledTimes(1); expect(component.state('show')).toEqual(false); - expect(historyMock.push.mock.calls[0]).toEqual([ '/', ]); + expect(historyMock.push.mock.calls[0]).toEqual([ '/']); }); }); \ No newline at end of file diff --git a/ui-react/src/components/dialogs/PerformActions.test.js b/ui-react/src/components/dialogs/PerformActions.test.js new file mode 100644 index 00000000..56fdcf39 --- /dev/null +++ b/ui-react/src/components/dialogs/PerformActions.test.js @@ -0,0 +1,88 @@ +/*- + * ============LICENSE_START======================================================= + * ONAP CLAMP + * ================================================================================ + * Copyright (C) 2019 AT&T Intellectual Property. All rights + * reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END============================================ + * =================================================================== + * + */ +import React from 'react'; +import { shallow } from 'enzyme'; +import PerformActions from './PerformActions'; +import LoopCache from '../../api/LoopCache'; +import LoopActionService from '../../api/LoopActionService'; + +describe('Verify PerformActions', () => { + + const loopCache = new LoopCache({ + "name": "LOOP_Jbv1z_v1_0_ResourceInstanceName1_tca" + }); + + it('Test the render method action failed', async () => { + const flushPromises = () => new Promise(setImmediate); + const historyMock = { push: jest.fn() }; + const updateLoopFunction = jest.fn(); + + LoopActionService.refreshStatus = jest.fn().mockImplementation(() => { + return Promise.resolve({ + ok: true, + status: 200, + json: () => {} + }); + }); + const jsdomAlert = window.alert; + window.alert = () => {}; + const component = shallow() + await flushPromises(); + component.update(); + + expect(historyMock.push.mock.calls[0]).toEqual([ '/']); + window.alert = jsdomAlert; + }); + + it('Test the render method action successful', async () => { + const flushPromises = () => new Promise(setImmediate); + const historyMock = { push: jest.fn() }; + const updateLoopFunction = jest.fn(); + + LoopActionService.performAction = jest.fn().mockImplementation(() => { + return Promise.resolve({ + ok: true, + status: 200, + json: () => {} + }); + }); + LoopActionService.refreshStatus = jest.fn().mockImplementation(() => { + return Promise.resolve({ + ok: true, + status: 200, + json: () => {} + }); + }); + const jsdomAlert = window.alert; + window.alert = () => {}; + const component = shallow() + await flushPromises(); + component.update(); + + expect(historyMock.push.mock.calls[0]).toEqual([ '/']); + window.alert = jsdomAlert; + }); + +}); diff --git a/ui-react/src/components/dialogs/RefreshStatus.test.js b/ui-react/src/components/dialogs/RefreshStatus.test.js new file mode 100644 index 00000000..cb782ad2 --- /dev/null +++ b/ui-react/src/components/dialogs/RefreshStatus.test.js @@ -0,0 +1,72 @@ +/*- + * ============LICENSE_START======================================================= + * ONAP CLAMP + * ================================================================================ + * Copyright (C) 2019 AT&T Intellectual Property. All rights + * reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END============================================ + * =================================================================== + * + */ +import React from 'react'; +import { shallow } from 'enzyme'; +import RefreshStatus from './RefreshStatus'; +import LoopCache from '../../api/LoopCache'; +import LoopActionService from '../../api/LoopActionService'; + +describe('Verify RefreshStatus', () => { + + const loopCache = new LoopCache({ + "name": "LOOP_Jbv1z_v1_0_ResourceInstanceName1_tca" + }); + + it('Test refresh status failed', async () => { + const flushPromises = () => new Promise(setImmediate); + const historyMock = { push: jest.fn() }; + + const jsdomAlert = window.alert; + window.alert = () => {}; + const component = shallow() + await flushPromises(); + component.update(); + + expect(historyMock.push.mock.calls[0]).toEqual([ '/']); + window.alert = jsdomAlert; + }); + + it('Test refresh status successful', async () => { + const flushPromises = () => new Promise(setImmediate); + const historyMock = { push: jest.fn() }; + const updateLoopFunction = jest.fn(); + + LoopActionService.refreshStatus = jest.fn().mockImplementation(() => { + return Promise.resolve({ + ok: true, + status: 200, + json: () => {} + }); + }); + const jsdomAlert = window.alert; + window.alert = () => {}; + const component = shallow() + await flushPromises(); + component.update(); + + expect(historyMock.push.mock.calls[0]).toEqual([ '/']); + window.alert = jsdomAlert; + }); + +}); diff --git a/ui-react/src/components/dialogs/UserInfo.test.js b/ui-react/src/components/dialogs/UserInfo.test.js index 186dac83..beddde14 100644 --- a/ui-react/src/components/dialogs/UserInfo.test.js +++ b/ui-react/src/components/dialogs/UserInfo.test.js @@ -35,7 +35,7 @@ describe('Verify UserInfo', () => { json: () => { return Promise.resolve({ "userName": "test", - "cldsVersion": "1.0.0", + "cldsVersion": "1.0.0" }); }}); }); -- cgit 1.2.3-korg