From 5b1e8ed247b7e23b1606908e38ee83858bec6082 Mon Sep 17 00:00:00 2001
From: Sandeep J <sandeejh@in.ibm.com>
Date: Tue, 2 Oct 2018 19:02:39 +0530
Subject: added test cases to SliStringUtilsTest

to increase code coverage

Issue-ID: CCSDK-595
Change-Id: Ice4f938166ab65ea316b683c3865dffc0483738c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
---
 .../core/slipluginutils/SliStringUtilsTest.java    | 501 +++++++++++----------
 1 file changed, 258 insertions(+), 243 deletions(-)

diff --git a/sliPluginUtils/provider/src/test/java/org/onap/ccsdk/sli/core/slipluginutils/SliStringUtilsTest.java b/sliPluginUtils/provider/src/test/java/org/onap/ccsdk/sli/core/slipluginutils/SliStringUtilsTest.java
index 9bf851d5..085d46ef 100644
--- a/sliPluginUtils/provider/src/test/java/org/onap/ccsdk/sli/core/slipluginutils/SliStringUtilsTest.java
+++ b/sliPluginUtils/provider/src/test/java/org/onap/ccsdk/sli/core/slipluginutils/SliStringUtilsTest.java
@@ -19,7 +19,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  * ============LICENSE_END=========================================================
- */
+ */ 
 
 package org.onap.ccsdk.sli.core.slipluginutils;
 
@@ -29,7 +29,7 @@ import static org.junit.Assert.assertThat;
 
 import java.util.HashMap;
 import java.util.Map;
- 
+
 import org.junit.Before;
 import org.junit.Test;
 import org.onap.ccsdk.sli.core.sli.SvcLogicContext;
@@ -40,246 +40,261 @@ import org.onap.ccsdk.sli.core.sli.SvcLogicException;
  *
  */
 public class SliStringUtilsTest {
-    private SvcLogicContext ctx;
-    private HashMap<String, String> param;
-    private SliStringUtils stringUtils = new SliStringUtils();
-
-    /**
-     * @throws java.lang.Exception
-     */
-    @Before
-    public void setUp() throws Exception {
-        this.ctx = new SvcLogicContext();
-        param = new HashMap<String, String>();
-    }
-
-    /**
-     * @throws SvcLogicException
-     * @see SliStringUtils#split(Map, SvcLogicContext)
-     */
-    @Test
-    public final void testSplit() throws SvcLogicException {
-        param.put("original_string", "one ## two ## three");
-        param.put("regex", " ## ");
-        param.put("ctx_memory_result_key", "result");
-
-        stringUtils.split(param, ctx);
-
-        assertThat(ctx.getAttribute("result[0]"), equalTo("one"));
-        assertThat(ctx.getAttribute("result[1]"), equalTo("two"));
-        assertThat(ctx.getAttribute("result[2]"), equalTo("three"));
-        assertThat(ctx.getAttribute("result_length"), equalTo("3"));
-    }
-
-    /**
-     * @throws SvcLogicException
-     * @see SliStringUtils#split(Map, SvcLogicContext)
-     */
-    @Test
-    public final void testSplit_limit() throws SvcLogicException {
-        param.put("original_string", "one ## two ## three");
-        param.put("regex", " ## ");
-        param.put("limit", "2");
-        param.put("ctx_memory_result_key", "result");
-
-        stringUtils.split(param, ctx);
-
-        assertThat(ctx.getAttribute("result[0]"), equalTo("one"));
-        assertThat(ctx.getAttribute("result[1]"), equalTo("two ## three"));
-        assertThat(ctx.getAttribute("result_length"), equalTo("2"));
-    }
-
-    @Test
-    public final void testSubString() throws SvcLogicException {
-        param.put("string","splitatgivenindex");
-        param.put("begin-index","0");
-        param.put("end-index","5");
-        param.put("result","result");
-
-        stringUtils.substring(param, ctx);
-
-        assertEquals("split", ctx.getAttribute("result"));
-    }
-
-    @Test
-    public final void testQuotedOrNull() throws SvcLogicException {
-        //param.put("nullString",null);
-        assertEquals("NULL",SliStringUtils.quotedOrNULL(null));
-    }
-
-    @Test
-    public void equalsIgnoreCaseTrue() throws SvcLogicException {
-        String sourceString = "HeLlOwORLD";
-        String targetSTring = "HELLOWORLD";
-        param.put("source", sourceString);
-        param.put("target", targetSTring);
-        assertEquals("true", SliStringUtils.equalsIgnoreCase(param, ctx));
-    }
-
-    @Test
-    public void equalsIgnoreCaseFalse() throws SvcLogicException {
-        String sourceString = "HeLlOwORLD";
-        String targetSTring = "goodbyeWORLD";
-        param.put("source", sourceString);
-        param.put("target", targetSTring);
-        assertEquals("false", SliStringUtils.equalsIgnoreCase(param, ctx));
-    }
-
-    @Test
-    public void toUpper() throws SvcLogicException {
-        String sourceString = "HeLlOwORLD";
-        param.put("source", sourceString);
-        String path = "my.unique.path.";
-        param.put("outputPath", path);
-        SliStringUtils.toUpper(param, ctx);
-        assertEquals(sourceString.toUpperCase(), ctx.getAttribute(path));
-    }
-
-    @Test
-    public void toLower() throws SvcLogicException {
-        String sourceString = "HeLlOwORLD";
-        param.put("source", sourceString);
-        String path = "my.unique.path.";
-        param.put("outputPath", path);
-        SliStringUtils.toLower(param, ctx);
-        assertEquals(sourceString.toLowerCase(), ctx.getAttribute(path));
-    }
-
-    @Test
-    public void containsTrue() throws SvcLogicException {
-        String sourceString = "Pizza";
-        String targetSTring = "izza";
-        param.put("source", sourceString);
-        param.put("target", targetSTring);
-        assertEquals("true", SliStringUtils.contains(param, ctx));
-    }
-
-    @Test
-    public void containsFalse() throws SvcLogicException {
-        String sourceString = "Pizza";
-        String targetSTring = "muffin";
-        param.put("source", sourceString);
-        param.put("target", targetSTring);
-        assertEquals("false", SliStringUtils.contains(param, ctx));
-    }
-
-    @Test
-    public void endsWithTrue() throws SvcLogicException {
-        String sourceString = "Pizza";
-        String targetSTring = "za";
-        param.put("source", sourceString);
-        param.put("target", targetSTring);
-        assertEquals("true", SliStringUtils.endsWith(param, ctx));
-    }
-
-    @Test
-    public void endsWithFalse() throws SvcLogicException {
-        String sourceString = "Pizza";
-        String targetSTring = "muffin";
-        param.put("source", sourceString);
-        param.put("target", targetSTring);
-        assertEquals("false", SliStringUtils.endsWith(param, ctx));
-    }
-
-    @Test
-    public void trim() throws SvcLogicException {
-        String sourceString = " H E L L O W O R L D";
-        String outputPath = "muffin";
-        param.put("source", sourceString);
-        param.put("outputPath", outputPath);
-        SliStringUtils.trim(param, ctx);
-        assertEquals(sourceString.trim(), ctx.getAttribute(outputPath));
-    }
-
-    @Test
-    public void getLength() throws SvcLogicException {
-        String sourceString = "SomeRandomString";
-        String outputPath = "muffin";
-        param.put("source", sourceString);
-        param.put("outputPath", outputPath);
-        SliStringUtils.getLength(param, ctx);
-        assertEquals(String.valueOf(sourceString.length()), ctx.getAttribute(outputPath));
-    }
-
-    @Test
-    public void startsWithFalse() throws SvcLogicException {
-        String sourceString = "Java";
-        String targetSTring = "DG";
-        param.put("source", sourceString);
-        param.put("target", targetSTring);
-        assertEquals("false", SliStringUtils.startsWith(param, ctx));
-    }
-
-    @Test
-    public void startsWithTrue() throws SvcLogicException {
-        String sourceString = "Java";
-        String targetSTring = "Ja";
-        param.put("source", sourceString);
-        param.put("target", targetSTring);
-        assertEquals("true", SliStringUtils.startsWith(param, ctx));
-    }
-
-    @Test
-    public void replace() throws SvcLogicException {
-        String sourceString = "cat Hello World cat";
-        String old = "cat";
-        String neww = "dog";
-        String outputPath = "out";
-
-        param.put("source", sourceString);
-        param.put("target", old);
-        param.put("replacement", neww);
-        param.put("outputPath", outputPath);
-        SliStringUtils.replace(param, ctx);
-        assertEquals(sourceString.replace(old, neww), ctx.getAttribute(outputPath));
-    }
-    
-    @Test
-    public void replaceAll() throws SvcLogicException {
-        String source = "cat Hello World cat";
-        String target = "\\s";
-        String replacement = "";
-        String outputPath = "out";
-
-        param.put("source", source);
-        param.put("target", target);
-        param.put("replacement", replacement);
-        param.put("outputPath", outputPath);
-        SliStringUtils.replaceAll(param, ctx);
-        assertEquals(source.replaceAll(target, replacement), ctx.getAttribute(outputPath));
-    }
-
-    @Test
-    public void concat() throws SvcLogicException {
-        String sourceString = "cat";
-        String targetString = "dog";
-        String outputPath = "out";
-
-        param.put("source", sourceString);
-        param.put("target", targetString);
-        param.put("outputPath", outputPath);
-        SliStringUtils.concat(param, ctx);
-        assertEquals(sourceString + targetString, ctx.getAttribute(outputPath));
-    }
-
-    @Test
-    public void urlEncode() throws SvcLogicException {
-        String sourceString = "102/GE100/SNJSCAMCJP8/SNJSCAMCJT4";
-        String outputPath = "out";
-
-        param.put("source", sourceString);
-        param.put("outputPath", outputPath);
-        SliStringUtils.urlEncode(param, ctx);
-        assertEquals("102%2FGE100%2FSNJSCAMCJP8%2FSNJSCAMCJT4", ctx.getAttribute(outputPath));
-    }
-    
-    @Test
-    public void testXmlEscapeText()
-    {
-        param.put("source", "102/GE100/SNJSCAMCJP8/SNJSCAMCJT4");
-        param.put("target", "target");
-        SliStringUtils.xmlEscapeText(param,ctx);
-        assertEquals("102/GE100/SNJSCAMCJP8/SNJSCAMCJT4",ctx.getAttribute("target"));
-    }
+	private SvcLogicContext ctx;
+	private HashMap<String, String> param;
+	private SliStringUtils stringUtils = new SliStringUtils();
+
+	/**
+	 * @throws java.lang.Exception
+	 */
+	@Before
+	public void setUp() throws Exception {
+		this.ctx = new SvcLogicContext();
+		param = new HashMap<String, String>();
+	}
+
+	/**
+	 * @throws SvcLogicException
+	 * @see SliStringUtils#split(Map, SvcLogicContext)
+	 */
+	@Test
+	public final void testSplit() throws SvcLogicException {
+		param.put("original_string", "one ## two ## three");
+		param.put("regex", " ## ");
+		param.put("ctx_memory_result_key", "result");
+
+		stringUtils.split(param, ctx);
+
+		assertThat(ctx.getAttribute("result[0]"), equalTo("one"));
+		assertThat(ctx.getAttribute("result[1]"), equalTo("two"));
+		assertThat(ctx.getAttribute("result[2]"), equalTo("three"));
+		assertThat(ctx.getAttribute("result_length"), equalTo("3"));
+	}
+
+	/**
+	 * @throws SvcLogicException
+	 * @see SliStringUtils#split(Map, SvcLogicContext)
+	 */
+	@Test
+	public final void testSplit_limit() throws SvcLogicException {
+		param.put("original_string", "one ## two ## three");
+		param.put("regex", " ## ");
+		param.put("limit", "2");
+		param.put("ctx_memory_result_key", "result");
+
+		stringUtils.split(param, ctx);
+
+		assertThat(ctx.getAttribute("result[0]"), equalTo("one"));
+		assertThat(ctx.getAttribute("result[1]"), equalTo("two ## three"));
+		assertThat(ctx.getAttribute("result_length"), equalTo("2"));
+	}
+
+	@Test
+	public final void testSubString() throws SvcLogicException {
+		param.put("string", "splitatgivenindex");
+		param.put("begin-index", "0");
+		param.put("end-index", "5");
+		param.put("result", "result");
+
+		stringUtils.substring(param, ctx);
+
+		assertEquals("split", ctx.getAttribute("result"));
+	}
+
+	@Test
+	public final void testQuotedOrNull() throws SvcLogicException {
+		// param.put("nullString",null);
+		assertEquals("NULL", SliStringUtils.quotedOrNULL(null));
+	}
+
+	@Test
+	public void equalsIgnoreCaseTrue() throws SvcLogicException {
+		String sourceString = "HeLlOwORLD";
+		String targetSTring = "HELLOWORLD";
+		param.put("source", sourceString);
+		param.put("target", targetSTring);
+		assertEquals("true", SliStringUtils.equalsIgnoreCase(param, ctx));
+	}
+
+	@Test
+	public void equalsIgnoreCaseFalse() throws SvcLogicException {
+		String sourceString = "HeLlOwORLD";
+		String targetSTring = "goodbyeWORLD";
+		param.put("source", sourceString);
+		param.put("target", targetSTring);
+		assertEquals("false", SliStringUtils.equalsIgnoreCase(param, ctx));
+	}
+
+	@Test
+	public void toUpper() throws SvcLogicException {
+		String sourceString = "HeLlOwORLD";
+		param.put("source", sourceString);
+		String path = "my.unique.path.";
+		param.put("outputPath", path);
+		SliStringUtils.toUpper(param, ctx);
+		assertEquals(sourceString.toUpperCase(), ctx.getAttribute(path));
+	}
+
+	@Test
+	public void toLower() throws SvcLogicException {
+		String sourceString = "HeLlOwORLD";
+		param.put("source", sourceString);
+		String path = "my.unique.path.";
+		param.put("outputPath", path);
+		SliStringUtils.toLower(param, ctx);
+		assertEquals(sourceString.toLowerCase(), ctx.getAttribute(path));
+	}
+
+	@Test
+	public void containsTrue() throws SvcLogicException {
+		String sourceString = "Pizza";
+		String targetSTring = "izza";
+		param.put("source", sourceString);
+		param.put("target", targetSTring);
+		assertEquals("true", SliStringUtils.contains(param, ctx));
+	}
+
+	@Test
+	public void containsFalse() throws SvcLogicException {
+		String sourceString = "Pizza";
+		String targetSTring = "muffin";
+		param.put("source", sourceString);
+		param.put("target", targetSTring);
+		assertEquals("false", SliStringUtils.contains(param, ctx));
+	}
+
+	@Test
+	public void endsWithTrue() throws SvcLogicException {
+		String sourceString = "Pizza";
+		String targetSTring = "za";
+		param.put("source", sourceString);
+		param.put("target", targetSTring);
+		assertEquals("true", SliStringUtils.endsWith(param, ctx));
+	}
+
+	@Test
+	public void endsWithFalse() throws SvcLogicException {
+		String sourceString = "Pizza";
+		String targetSTring = "muffin";
+		param.put("source", sourceString);
+		param.put("target", targetSTring);
+		assertEquals("false", SliStringUtils.endsWith(param, ctx));
+	}
+
+	@Test
+	public void trim() throws SvcLogicException {
+		String sourceString = " H E L L O W O R L D";
+		String outputPath = "muffin";
+		param.put("source", sourceString);
+		param.put("outputPath", outputPath);
+		SliStringUtils.trim(param, ctx);
+		assertEquals(sourceString.trim(), ctx.getAttribute(outputPath));
+	}
+
+	@Test
+	public void getLength() throws SvcLogicException {
+		String sourceString = "SomeRandomString";
+		String outputPath = "muffin";
+		param.put("source", sourceString);
+		param.put("outputPath", outputPath);
+		SliStringUtils.getLength(param, ctx);
+		assertEquals(String.valueOf(sourceString.length()), ctx.getAttribute(outputPath));
+	}
+
+	@Test
+	public void startsWithFalse() throws SvcLogicException {
+		String sourceString = "Java";
+		String targetSTring = "DG";
+		param.put("source", sourceString);
+		param.put("target", targetSTring);
+		assertEquals("false", SliStringUtils.startsWith(param, ctx));
+	}
+
+	@Test
+	public void startsWithTrue() throws SvcLogicException {
+		String sourceString = "Java";
+		String targetSTring = "Ja";
+		param.put("source", sourceString);
+		param.put("target", targetSTring);
+		assertEquals("true", SliStringUtils.startsWith(param, ctx));
+	}
+
+	@Test
+	public void replace() throws SvcLogicException {
+		String sourceString = "cat Hello World cat";
+		String old = "cat";
+		String neww = "dog";
+		String outputPath = "out";
+
+		param.put("source", sourceString);
+		param.put("target", old);
+		param.put("replacement", neww);
+		param.put("outputPath", outputPath);
+		SliStringUtils.replace(param, ctx);
+		assertEquals(sourceString.replace(old, neww), ctx.getAttribute(outputPath));
+	}
+
+	@Test
+	public void replaceAll() throws SvcLogicException {
+		String source = "cat Hello World cat";
+		String target = "\\s";
+		String replacement = "";
+		String outputPath = "out";
+
+		param.put("source", source);
+		param.put("target", target);
+		param.put("replacement", replacement);
+		param.put("outputPath", outputPath);
+		SliStringUtils.replaceAll(param, ctx);
+		assertEquals(source.replaceAll(target, replacement), ctx.getAttribute(outputPath));
+	}
+
+	@Test
+	public void concat() throws SvcLogicException {
+		String sourceString = "cat";
+		String targetString = "dog";
+		String outputPath = "out";
+
+		param.put("source", sourceString);
+		param.put("target", targetString);
+		param.put("outputPath", outputPath);
+		SliStringUtils.concat(param, ctx);
+		assertEquals(sourceString + targetString, ctx.getAttribute(outputPath));
+	}
+
+	@Test
+	public void urlEncode() throws SvcLogicException {
+		String sourceString = "102/GE100/SNJSCAMCJP8/SNJSCAMCJT4";
+		String outputPath = "out";
+
+		param.put("source", sourceString);
+		param.put("outputPath", outputPath);
+		SliStringUtils.urlEncode(param, ctx);
+		assertEquals("102%2FGE100%2FSNJSCAMCJP8%2FSNJSCAMCJT4", ctx.getAttribute(outputPath));
+	}
+
+	@Test
+	public void testXmlEscapeText() {
+		param.put("source", "102/GE100/SNJSCAMCJP8/SNJSCAMCJT4");
+		param.put("target", "target");
+		SliStringUtils.xmlEscapeText(param, ctx);
+		assertEquals("102/GE100/SNJSCAMCJP8/SNJSCAMCJT4", ctx.getAttribute("target"));
+	}
+
+	@Test(expected = Exception.class)
+	public void testSplitForEmptyParams() throws Exception {
+		SliStringUtils utils = new SliStringUtils();
+		ctx = new SvcLogicContext();
+		param = new HashMap<>();
+		utils.split(param, ctx);
+	}
+
+	@Test(expected = Exception.class)
+	public void testSubstringForEmptyParams() throws Exception {
+		SliStringUtils utils = new SliStringUtils();
+		ctx = new SvcLogicContext();
+		param = new HashMap<>();
+		utils.substring(param, ctx);
+	}
 
 }
-- 
cgit 1.2.3-korg