From 2a392e229f81a0a8228e6160ab4614a0fbc60621 Mon Sep 17 00:00:00 2001 From: "ramu.n" Date: Mon, 25 Sep 2017 16:52:45 +0530 Subject: Some minor refinements in CCSDK SLI Core module *Remove useless braces while logging exception stack trace *Register all DG nodes in SvcLogicParser Test file Change-Id: I7916bec20e36e1def15c24806da2f7e01e79bf4b Issue-Id: CCSDK-106 Signed-off-by: Ramu N --- .../src/main/java/org/onap/ccsdk/sli/core/sli/SvcLogicParser.java | 4 ++-- .../java/org/onap/ccsdk/sli/core/sli/ITCaseSvcLogicParser.java | 7 +++++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/sli/common/src/main/java/org/onap/ccsdk/sli/core/sli/SvcLogicParser.java b/sli/common/src/main/java/org/onap/ccsdk/sli/core/sli/SvcLogicParser.java index ee192d62..a33ba476 100644 --- a/sli/common/src/main/java/org/onap/ccsdk/sli/core/sli/SvcLogicParser.java +++ b/sli/common/src/main/java/org/onap/ccsdk/sli/core/sli/SvcLogicParser.java @@ -385,7 +385,7 @@ public class SvcLogicParser { saxParser.parse(fileName, new SvcLogicHandler(graphs, store)); } catch (Exception e) { - LOGGER.error("Parsing failed {}", e); + LOGGER.error("Parsing failed ", e); String msg = e.getMessage(); if (msg != null) { throw new SvcLogicException("Compiler error: " + fileName + " @ " + msg); @@ -412,7 +412,7 @@ public class SvcLogicParser { try { SvcLogicParser.load(xmlfile, store); } catch (Exception e) { - LOGGER.error("Load failed {}", e); + LOGGER.error("Load failed ", e); } } else { SvcLogicParser.usage(); diff --git a/sli/common/src/test/java/org/onap/ccsdk/sli/core/sli/ITCaseSvcLogicParser.java b/sli/common/src/test/java/org/onap/ccsdk/sli/core/sli/ITCaseSvcLogicParser.java index 8bf748aa..7af4c1c5 100644 --- a/sli/common/src/test/java/org/onap/ccsdk/sli/core/sli/ITCaseSvcLogicParser.java +++ b/sli/common/src/test/java/org/onap/ccsdk/sli/core/sli/ITCaseSvcLogicParser.java @@ -96,6 +96,13 @@ public class ITCaseSvcLogicParser { store.registerNodeType("release"); store.registerNodeType("for"); store.registerNodeType("set"); + store.registerNodeType("call"); + store.registerNodeType("delete"); + store.registerNodeType("execute"); + store.registerNodeType("notify"); + store.registerNodeType("save"); + store.registerNodeType("update"); + store.registerNodeType("break"); } @Before -- cgit 1.2.3-korg