From 148c15b82dfc2025dc1c4a19b55293cdf3e9db2f Mon Sep 17 00:00:00 2001 From: surya-huawei Date: Sun, 17 Sep 2017 22:53:41 +0530 Subject: Fix Sonar issues in sli/core module One major issue * Use try with resources instead of try Issue-Id: CCSDK-87 Change-Id: Ic30016f70ebc355f80a73c9e4632b7971d2b87be Signed-off-by: surya-huawei --- .../org/onap/ccsdk/sli/core/sli/recording/FileRecorder.java | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/sli/recording/src/main/java/org/onap/ccsdk/sli/core/sli/recording/FileRecorder.java b/sli/recording/src/main/java/org/onap/ccsdk/sli/core/sli/recording/FileRecorder.java index 4a60de95..772906e5 100644 --- a/sli/recording/src/main/java/org/onap/ccsdk/sli/core/sli/recording/FileRecorder.java +++ b/sli/recording/src/main/java/org/onap/ccsdk/sli/core/sli/recording/FileRecorder.java @@ -82,7 +82,6 @@ public class FileRecorder implements SvcLogicRecorder { } File recordFile = new File(fileName); - PrintWriter recPrinter = null; FileWriter fileWriter = null; Date now = new Date(); @@ -94,10 +93,9 @@ public class FileRecorder implements SvcLogicRecorder { record = record.replaceFirst("__TIMESTAMP__", dateFmt.format(now)); } - try + try ( PrintWriter recPrinter = new PrintWriter(fileWriter = new + FileWriter(recordFile, true))) { - - recPrinter = new PrintWriter(fileWriter = new FileWriter(recordFile, true)); recPrinter.println(record); } catch (Exception e) @@ -106,10 +104,6 @@ public class FileRecorder implements SvcLogicRecorder { } finally { - if (recPrinter != null) - { - recPrinter.close(); - } if (fileWriter != null) { try { -- cgit 1.2.3-korg