From e816a5916736d263227f5a800561ead9ad81ce27 Mon Sep 17 00:00:00 2001
From: Dan Timoney <dtimoney@att.com>
Date: Thu, 3 Sep 2020 08:56:01 -0400
Subject: Address javadoc build issues

maven-javadoc-plugin started to fail when using java 11 compiler.  Some
issues are addressed in latest version of plugin (3.2.0), but it appears
some issues remain.  To address this, we use the latest plugin version
and configure maven to continue if javadoc errors occur. Note: this issue
is currently causing verify builds to fail - thus, this is a blocking
issue.

Change-Id: I0a9882b4b93ea18b29e2d53d269cf70dda77a4d1
Issue-ID: CCSDK-2728
Signed-off-by: Dan Timoney <dtimoney@att.com>
---
 .gitignore                                                       | 1 +
 odlparent/binding-parent/pom.xml                                 | 8 ++++++++
 odlparent/bundle-parent/pom.xml                                  | 8 ++++++++
 odlparent/feature-repo-parent/pom.xml                            | 8 ++++++++
 odlparent/karaf4-parent/pom.xml                                  | 8 ++++++++
 odlparent/mdsal-it-parent/pom.xml                                | 8 ++++++++
 odlparent/odlparent-lite/pom.xml                                 | 8 ++++++++
 odlparent/odlparent/pom.xml                                      | 8 ++++++++
 odlparent/setup/src/main/resources/pom-template.xml              | 8 ++++++++
 odlparent/single-feature-parent/pom.xml                          | 8 ++++++++
 springboot/spring-boot-setup/src/main/resources/pom-template.xml | 3 ++-
 springboot/springboot1/pom.xml                                   | 3 ++-
 springboot/springboot2/pom.xml                                   | 3 ++-
 13 files changed, 79 insertions(+), 3 deletions(-)

diff --git a/.gitignore b/.gitignore
index ebb44b7b..bd2cc03b 100755
--- a/.gitignore
+++ b/.gitignore
@@ -10,6 +10,7 @@ org.eclipse.core.resources.prefs
 .checkstyle
 maven-eclipse.xml
 workspace
+.vscode
 
 ## Compilation Files ##
 *.class
diff --git a/odlparent/binding-parent/pom.xml b/odlparent/binding-parent/pom.xml
index 0a9f3661..8aec6fff 100644
--- a/odlparent/binding-parent/pom.xml
+++ b/odlparent/binding-parent/pom.xml
@@ -564,6 +564,14 @@
                         <version>7.1.1</version>
                     </configuration>
                 </plugin>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-javadoc-plugin</artifactId>
+                    <version>3.2.0</version>
+                    <configuration>
+                        <failOnError>false</failOnError>
+                    </configuration>
+                </plugin>
             </plugins>
         </pluginManagement>
         <plugins>
diff --git a/odlparent/bundle-parent/pom.xml b/odlparent/bundle-parent/pom.xml
index e746185a..ad6b7ba3 100644
--- a/odlparent/bundle-parent/pom.xml
+++ b/odlparent/bundle-parent/pom.xml
@@ -564,6 +564,14 @@
                         <version>7.1.1</version>
                     </configuration>
                 </plugin>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-javadoc-plugin</artifactId>
+                    <version>3.2.0</version>
+                    <configuration>
+                        <failOnError>false</failOnError>
+                    </configuration>
+                </plugin>
             </plugins>
         </pluginManagement>
         <plugins>
diff --git a/odlparent/feature-repo-parent/pom.xml b/odlparent/feature-repo-parent/pom.xml
index 18eb3f33..21d108d5 100644
--- a/odlparent/feature-repo-parent/pom.xml
+++ b/odlparent/feature-repo-parent/pom.xml
@@ -564,6 +564,14 @@
                         <version>7.1.1</version>
                     </configuration>
                 </plugin>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-javadoc-plugin</artifactId>
+                    <version>3.2.0</version>
+                    <configuration>
+                        <failOnError>false</failOnError>
+                    </configuration>
+                </plugin>
             </plugins>
         </pluginManagement>
         <plugins>
diff --git a/odlparent/karaf4-parent/pom.xml b/odlparent/karaf4-parent/pom.xml
index 0bcb5c2e..1c7305c1 100644
--- a/odlparent/karaf4-parent/pom.xml
+++ b/odlparent/karaf4-parent/pom.xml
@@ -564,6 +564,14 @@
                         <version>7.1.1</version>
                     </configuration>
                 </plugin>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-javadoc-plugin</artifactId>
+                    <version>3.2.0</version>
+                    <configuration>
+                        <failOnError>false</failOnError>
+                    </configuration>
+                </plugin>
             </plugins>
         </pluginManagement>
         <plugins>
diff --git a/odlparent/mdsal-it-parent/pom.xml b/odlparent/mdsal-it-parent/pom.xml
index 24ab9537..e23a4739 100644
--- a/odlparent/mdsal-it-parent/pom.xml
+++ b/odlparent/mdsal-it-parent/pom.xml
@@ -564,6 +564,14 @@
                         <version>7.1.1</version>
                     </configuration>
                 </plugin>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-javadoc-plugin</artifactId>
+                    <version>3.2.0</version>
+                    <configuration>
+                        <failOnError>false</failOnError>
+                    </configuration>
+                </plugin>
             </plugins>
         </pluginManagement>
         <plugins>
diff --git a/odlparent/odlparent-lite/pom.xml b/odlparent/odlparent-lite/pom.xml
index 70001a76..1eb6a3d3 100644
--- a/odlparent/odlparent-lite/pom.xml
+++ b/odlparent/odlparent-lite/pom.xml
@@ -564,6 +564,14 @@
                         <version>7.1.1</version>
                     </configuration>
                 </plugin>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-javadoc-plugin</artifactId>
+                    <version>3.2.0</version>
+                    <configuration>
+                        <failOnError>false</failOnError>
+                    </configuration>
+                </plugin>
             </plugins>
         </pluginManagement>
         <plugins>
diff --git a/odlparent/odlparent/pom.xml b/odlparent/odlparent/pom.xml
index 8b605eee..13c8f47a 100644
--- a/odlparent/odlparent/pom.xml
+++ b/odlparent/odlparent/pom.xml
@@ -564,6 +564,14 @@
                         <version>7.1.1</version>
                     </configuration>
                 </plugin>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-javadoc-plugin</artifactId>
+                    <version>3.2.0</version>
+                    <configuration>
+                        <failOnError>false</failOnError>
+                    </configuration>
+                </plugin>
             </plugins>
         </pluginManagement>
         <plugins>
diff --git a/odlparent/setup/src/main/resources/pom-template.xml b/odlparent/setup/src/main/resources/pom-template.xml
index f3bf114f..d6a9b46a 100755
--- a/odlparent/setup/src/main/resources/pom-template.xml
+++ b/odlparent/setup/src/main/resources/pom-template.xml
@@ -564,6 +564,14 @@
                         <version>7.1.1</version>
                     </configuration>
                 </plugin>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-javadoc-plugin</artifactId>
+                    <version>3.2.0</version>
+                    <configuration>
+                        <failOnError>false</failOnError>
+                    </configuration>
+                </plugin>
             </plugins>
         </pluginManagement>
         <plugins>
diff --git a/odlparent/single-feature-parent/pom.xml b/odlparent/single-feature-parent/pom.xml
index ffe773e3..5e4a8e0b 100644
--- a/odlparent/single-feature-parent/pom.xml
+++ b/odlparent/single-feature-parent/pom.xml
@@ -564,6 +564,14 @@
                         <version>7.1.1</version>
                     </configuration>
                 </plugin>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-javadoc-plugin</artifactId>
+                    <version>3.2.0</version>
+                    <configuration>
+                        <failOnError>false</failOnError>
+                    </configuration>
+                </plugin>
             </plugins>
         </pluginManagement>
         <plugins>
diff --git a/springboot/spring-boot-setup/src/main/resources/pom-template.xml b/springboot/spring-boot-setup/src/main/resources/pom-template.xml
index e92abbac..cfbf017b 100644
--- a/springboot/spring-boot-setup/src/main/resources/pom-template.xml
+++ b/springboot/spring-boot-setup/src/main/resources/pom-template.xml
@@ -436,7 +436,7 @@
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-javadoc-plugin</artifactId>
-                    <version>2.10.4</version>
+                    <version>3.2.0</version>
                     <configuration>
                         <additionalDependencies>
                             <additionalDependency>
@@ -480,6 +480,7 @@
                                 <version>\${commons.lang.version}</version>
                             </additionalDependency>
                         </additionalDependencies>
+                        <failOnError>false</failOnError>
                     </configuration>
                     <executions>
                         <execution>
diff --git a/springboot/springboot1/pom.xml b/springboot/springboot1/pom.xml
index 1752dcee..00e8f0b1 100644
--- a/springboot/springboot1/pom.xml
+++ b/springboot/springboot1/pom.xml
@@ -436,7 +436,7 @@
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-javadoc-plugin</artifactId>
-                    <version>2.10.4</version>
+                    <version>3.2.0</version>
                     <configuration>
                         <additionalDependencies>
                             <additionalDependency>
@@ -480,6 +480,7 @@
                                 <version>${commons.lang.version}</version>
                             </additionalDependency>
                         </additionalDependencies>
+                        <failOnError>false</failOnError>
                     </configuration>
                     <executions>
                         <execution>
diff --git a/springboot/springboot2/pom.xml b/springboot/springboot2/pom.xml
index dfd87f82..b604cf00 100644
--- a/springboot/springboot2/pom.xml
+++ b/springboot/springboot2/pom.xml
@@ -436,7 +436,7 @@
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-javadoc-plugin</artifactId>
-                    <version>2.10.4</version>
+                    <version>3.2.0</version>
                     <configuration>
                         <additionalDependencies>
                             <additionalDependency>
@@ -480,6 +480,7 @@
                                 <version>${commons.lang.version}</version>
                             </additionalDependency>
                         </additionalDependencies>
+                        <failOnError>false</failOnError>
                     </configuration>
                     <executions>
                         <execution>
-- 
cgit 1.2.3-korg