diff options
16 files changed, 233 insertions, 64 deletions
diff --git a/a1-policy-management/api/pms-api.json b/a1-policy-management/api/pms-api.json index d34e94be..95bc6580 100644 --- a/a1-policy-management/api/pms-api.json +++ b/a1-policy-management/api/pms-api.json @@ -1153,7 +1153,7 @@ "required": true }, "description": "The URL to this call is registerred at Service registration.", - "operationId": "jobStatusCallback", + "operationId": "serviceCallback", "responses": {"200": { "description": "OK", "content": {"application/json": {"schema": {"$ref": "#/components/schemas/void"}}} diff --git a/a1-policy-management/api/pms-api.yaml b/a1-policy-management/api/pms-api.yaml index b106d11c..b1444032 100644 --- a/a1-policy-management/api/pms-api.yaml +++ b/a1-policy-management/api/pms-api.yaml @@ -1033,7 +1033,7 @@ paths: - Callbacks summary: Callback for Near-RT RIC status description: The URL to this call is registerred at Service registration. - operationId: jobStatusCallback + operationId: serviceCallback requestBody: content: application/json: diff --git a/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/BeanFactory.java b/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/BeanFactory.java index 4b5c2f09..93fd2f77 100644 --- a/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/BeanFactory.java +++ b/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/BeanFactory.java @@ -51,8 +51,8 @@ public class BeanFactory { } @Bean - public Services getServices() { - return new Services(); + public Services getServices(@Autowired ApplicationConfig applicationConfig) { + return new Services(applicationConfig); } @Bean diff --git a/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/controllers/ServiceCallbacks.java b/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/controllers/ServiceCallbacks.java index f9e446e4..b028cd63 100644 --- a/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/controllers/ServiceCallbacks.java +++ b/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/controllers/ServiceCallbacks.java @@ -51,35 +51,28 @@ public class ServiceCallbacks { this.restClient = restClientFactory.createRestClientNoHttpProxy(""); } - public void notifyServicesRicSynchronized(Ric ric, Services services) { - createTask(ric, services).subscribe(numberOfServices -> logger.debug("Services {} notified", numberOfServices), - throwable -> logger.error("Service notification failed, cause: {}", throwable.getMessage()), - () -> logger.debug("All services notified")); - - } - - private Mono<Integer> createTask(Ric ric, Services services) { + public Flux<Service> notifyServicesRicAvailable(Ric ric, Services services) { + final int CONCURRENCY = 10; return Flux.fromIterable(services.getAll()) // - .flatMap(service -> notifyServiceRicSynchronized(ric, service)) // - .collectList() // - .flatMap(okResponses -> Mono.just(Integer.valueOf(okResponses.size()))); // + .flatMap(service -> notifyService(ric, service, ServiceCallbackInfo.EventType.AVAILABLE), CONCURRENCY); // } - private Mono<String> notifyServiceRicSynchronized(Ric ric, Service service) { + private Mono<Service> notifyService(Ric ric, Service service, ServiceCallbackInfo.EventType eventType) { if (service.getCallbackUrl().isEmpty()) { return Mono.empty(); } - ServiceCallbackInfo request = new ServiceCallbackInfo(ric.id(), ServiceCallbackInfo.EventType.AVAILABLE); + ServiceCallbackInfo request = new ServiceCallbackInfo(ric.id(), eventType); String body = gson.toJson(request); return restClient.post(service.getCallbackUrl(), body) .doOnNext(resp -> logger.debug("Invoking service {} callback, ric: {}", service.getName(), ric.id())) .onErrorResume(throwable -> { - logger.error("Service: {}, callback: {} failed: {}", service.getName(), service.getCallbackUrl(), + logger.warn("Service: {}, callback: {} failed: {}", service.getName(), service.getCallbackUrl(), throwable.toString()); return Mono.empty(); - }); + }) // + .flatMap(resp -> Mono.just(service)); } } diff --git a/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/repository/PolicyTypes.java b/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/repository/PolicyTypes.java index ad3270cb..3248f214 100644 --- a/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/repository/PolicyTypes.java +++ b/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/repository/PolicyTypes.java @@ -120,10 +120,10 @@ public class PolicyTypes { this.types.put(type.getId(), type); } logger.debug("Restored type database,no of types: {}", this.types.size()); - } catch (IOException e) { - logger.warn("Could not restore policy type database : {}", e.getMessage()); } catch (ServiceException e) { logger.debug("Could not restore policy type database : {}", e.getMessage()); + } catch (Exception e) { + logger.warn("Could not restore policy type database : {}", e.getMessage()); } } diff --git a/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/repository/Service.java b/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/repository/Service.java index 3c7c53a1..90ae28c5 100644 --- a/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/repository/Service.java +++ b/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/repository/Service.java @@ -20,6 +20,13 @@ package org.onap.ccsdk.oran.a1policymanagementservice.repository; +import com.google.gson.Gson; +import com.google.gson.GsonBuilder; +import com.google.gson.TypeAdapter; +import com.google.gson.stream.JsonReader; +import com.google.gson.stream.JsonWriter; + +import java.io.IOException; import java.time.Duration; import java.time.Instant; @@ -27,6 +34,40 @@ import lombok.Getter; import lombok.Setter; public class Service { + + static class InstantAdapter extends TypeAdapter<Instant> { + @Override + public Instant read(JsonReader reader) throws IOException { + reader.skipValue(); + return Instant.now(); // Pretend that the last ping was now (after a restart) + } + + @Override + public void write(JsonWriter writer, Instant value) throws IOException { + writer.value(value.toString()); + } + } + + static class DurationAdapter extends TypeAdapter<Duration> { + @Override + public Duration read(JsonReader reader) throws IOException { + long value = reader.nextLong(); + return Duration.ofNanos(value); + } + + @Override + public void write(JsonWriter writer, Duration value) throws IOException { + writer.value(value.toNanos()); + } + } + + public static Gson createGson() { + return new GsonBuilder() // + .registerTypeAdapter(Instant.class, new Service.InstantAdapter()) // + .registerTypeAdapter(Duration.class, new Service.DurationAdapter()) // + .create(); + } + @Getter private final String name; diff --git a/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/repository/Services.java b/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/repository/Services.java index 63633f67..2d2f6364 100644 --- a/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/repository/Services.java +++ b/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/repository/Services.java @@ -20,19 +20,37 @@ package org.onap.ccsdk.oran.a1policymanagementservice.repository; +import com.google.gson.Gson; + +import java.io.File; +import java.io.FileOutputStream; +import java.io.IOException; +import java.io.PrintStream; +import java.nio.file.Files; +import java.nio.file.Path; import java.util.HashMap; import java.util.Map; import java.util.Vector; +import org.onap.ccsdk.oran.a1policymanagementservice.configuration.ApplicationConfig; import org.onap.ccsdk.oran.a1policymanagementservice.exceptions.ServiceException; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.util.FileSystemUtils; public class Services { private static final Logger logger = LoggerFactory.getLogger(Services.class); + private static Gson gson = Service.createGson(); + private final ApplicationConfig appConfig; private Map<String, Service> registeredServices = new HashMap<>(); + public Services(@Autowired ApplicationConfig appConfig) { + this.appConfig = appConfig; + restoreFromDatabase(); + } + public synchronized Service getService(String name) throws ServiceException { Service s = registeredServices.get(name); if (s == null) { @@ -49,6 +67,7 @@ public class Services { logger.debug("Put service: {}", service.getName()); service.keepAlive(); registeredServices.put(service.getName(), service); + store(service); } public synchronized Iterable<Service> getAll() { @@ -56,7 +75,14 @@ public class Services { } public synchronized void remove(String name) { - registeredServices.remove(name); + Service service = registeredServices.remove(name); + if (service != null) { + try { + Files.delete(getPath(service)); + } catch (Exception e) { + + } + } } public synchronized int size() { @@ -65,5 +91,59 @@ public class Services { public synchronized void clear() { registeredServices.clear(); + try { + FileSystemUtils.deleteRecursively(getDatabasePath()); + } catch (Exception e) { + logger.warn("Could not delete services database : {}", e.getMessage()); + } + } + + public void store(Service service) { + try { + Files.createDirectories(getDatabasePath()); + try (PrintStream out = new PrintStream(new FileOutputStream(getFile(service)))) { + String str = gson.toJson(service); + out.print(str); + } + } catch (ServiceException e) { + logger.debug("Could not store service: {} {}", service.getName(), e.getMessage()); + } catch (IOException e) { + logger.warn("Could not store pservice: {} {}", service.getName(), e.getMessage()); + } + } + + private File getFile(Service service) throws ServiceException { + return getPath(service).toFile(); + } + + private Path getPath(Service service) throws ServiceException { + return Path.of(getDatabaseDirectory(), service.getName() + ".json"); + } + + void restoreFromDatabase() { + try { + Files.createDirectories(getDatabasePath()); + for (File file : getDatabasePath().toFile().listFiles()) { + String json = Files.readString(file.toPath()); + Service service = gson.fromJson(json, Service.class); + this.registeredServices.put(service.getName(), service); + } + logger.debug("Restored type database,no of services: {}", this.registeredServices.size()); + } catch (ServiceException e) { + logger.debug("Could not restore services database : {}", e.getMessage()); + } catch (Exception e) { + logger.warn("Could not restore services database : {}", e.getMessage()); + } + } + + private String getDatabaseDirectory() throws ServiceException { + if (appConfig.getVardataDirectory() == null) { + throw new ServiceException("No storage provided"); + } + return appConfig.getVardataDirectory() + "/database/services"; + } + + private Path getDatabasePath() throws ServiceException { + return Path.of(getDatabaseDirectory()); } } diff --git a/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/tasks/RefreshConfigTask.java b/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/tasks/RefreshConfigTask.java index c733cb0d..faef863e 100644 --- a/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/tasks/RefreshConfigTask.java +++ b/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/tasks/RefreshConfigTask.java @@ -35,6 +35,7 @@ import org.onap.ccsdk.oran.a1policymanagementservice.configuration.ApplicationCo import org.onap.ccsdk.oran.a1policymanagementservice.configuration.ApplicationConfig.RicConfigUpdate; import org.onap.ccsdk.oran.a1policymanagementservice.configuration.ApplicationConfigParser; import org.onap.ccsdk.oran.a1policymanagementservice.configuration.ConfigurationFile; +import org.onap.ccsdk.oran.a1policymanagementservice.controllers.ServiceCallbacks; import org.onap.ccsdk.oran.a1policymanagementservice.repository.Policies; import org.onap.ccsdk.oran.a1policymanagementservice.repository.PolicyTypes; import org.onap.ccsdk.oran.a1policymanagementservice.repository.Ric; @@ -233,9 +234,11 @@ public class RefreshConfigTask { RicConfigUpdate.Type event = updatedInfo.getType(); if (event == RicConfigUpdate.Type.ADDED) { logger.debug("RIC added {}", ricId); - Ric ric = new Ric(updatedInfo.getRicConfig()); - return trySyncronizeSupportedTypes(ric) // + + return trySyncronizeSupportedTypes(new Ric(updatedInfo.getRicConfig())) // .flatMap(this::addRic) // + .flatMap(this::notifyServicesRicAvailable) // + .doOnNext(ric -> ric.setState(RicState.AVAILABLE)) // .flatMap(notUsed -> Mono.just(event)); } else if (event == RicConfigUpdate.Type.REMOVED) { logger.debug("RIC removed {}", ricId); @@ -263,11 +266,16 @@ public class RefreshConfigTask { } logger.debug("Added RIC: {}", ric.id()); - ric.setState(RicState.AVAILABLE); - return Mono.just(ric); } + private Mono<Ric> notifyServicesRicAvailable(Ric ric) { + ServiceCallbacks callbacks = new ServiceCallbacks(this.restClientFactory); + return callbacks.notifyServicesRicAvailable(ric, services) // + .collectList() // + .flatMap(list -> Mono.just(ric)); + } + /** * Reads the configuration from file. */ diff --git a/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/tasks/RicSynchronizationTask.java b/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/tasks/RicSynchronizationTask.java index 6ac104ca..0ccccb73 100644 --- a/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/tasks/RicSynchronizationTask.java +++ b/a1-policy-management/src/main/java/org/onap/ccsdk/oran/a1policymanagementservice/tasks/RicSynchronizationTask.java @@ -108,7 +108,7 @@ public class RicSynchronizationTask { logger.warn("Synchronization failure for ric: {}, reason: {}", ric.id(), t.getMessage()); // ric.setState(RicState.UNAVAILABLE); // }) // - .doOnNext(notUsed -> onSynchronizationComplete(ric)) // + .flatMap(notUsed -> onSynchronizationComplete(ric)) // .onErrorResume(t -> Mono.just(ric)); } @@ -142,14 +142,17 @@ public class RicSynchronizationTask { return Flux.concat(synchronizedTypes, policiesDeletedInRic, policiesRecreatedInRic); } - private void onSynchronizationComplete(Ric ric) { + private Mono<Ric> onSynchronizationComplete(Ric ric) { if (this.rics.get(ric.id()) == null) { logger.debug("Policies removed in removed ric: {}", ric.id()); - return; + return Mono.empty(); } logger.debug("Synchronization completed for: {}", ric.id()); ric.setState(RicState.AVAILABLE); - notifyServices(ric); + ServiceCallbacks callbacks = new ServiceCallbacks(this.restClientFactory); + return callbacks.notifyServicesRicAvailable(ric, services) // + .collectList() // + .flatMap(list -> Mono.just(ric)); } private Flux<Object> deleteAllPolicyInstances(Ric ric, Throwable t) { @@ -165,11 +168,6 @@ public class RicSynchronizationTask { return Flux.concat(synchronizedTypes, deletePoliciesInRic); } - void notifyServices(Ric ric) { - ServiceCallbacks callbacks = new ServiceCallbacks(this.restClientFactory); - callbacks.notifyServicesRicSynchronized(ric, services); - } - private Mono<PolicyType> getPolicyType(String policyTypeId, A1Client a1Client) { if (policyTypes.contains(policyTypeId)) { return Mono.just(policyTypes.get(policyTypeId)); diff --git a/a1-policy-management/src/test/java/org/onap/ccsdk/oran/a1policymanagementservice/controllers/v2/ApplicationTest.java b/a1-policy-management/src/test/java/org/onap/ccsdk/oran/a1policymanagementservice/controllers/v2/ApplicationTest.java index 5ffe5153..84bc47ad 100644 --- a/a1-policy-management/src/test/java/org/onap/ccsdk/oran/a1policymanagementservice/controllers/v2/ApplicationTest.java +++ b/a1-policy-management/src/test/java/org/onap/ccsdk/oran/a1policymanagementservice/controllers/v2/ApplicationTest.java @@ -171,6 +171,7 @@ class ApplicationTest { services.clear(); a1ClientFactory.reset(); this.rAppSimulator.getTestResults().clear(); + this.a1ClientFactory.setPolicyTypes(policyTypes); // Default same types in RIC and in this app } @AfterEach @@ -200,11 +201,9 @@ class ApplicationTest { } @Test - void testPersistency() throws ServiceException { + void testPersistencyPolicies() throws ServiceException { Ric ric = this.addRic("ric1"); PolicyType type = this.addPolicyType("type1", ric.id()); - PolicyTypes types = new PolicyTypes(this.applicationConfig); - assertThat(types.size()).isEqualTo(1); final int noOfPolicies = 100; for (int i = 0; i < noOfPolicies; ++i) { @@ -213,27 +212,74 @@ class ApplicationTest { { Policies policies = new Policies(this.applicationConfig); - policies.restoreFromDatabase(ric, types); + policies.restoreFromDatabase(ric, this.policyTypes); assertThat(policies.size()).isEqualTo(noOfPolicies); } { restClient().delete("/policies/id2").block(); Policies policies = new Policies(this.applicationConfig); - policies.restoreFromDatabase(ric, types); + policies.restoreFromDatabase(ric, this.policyTypes); assertThat(policies.size()).isEqualTo(noOfPolicies - 1); } + } - { - // Test adding the RIC from configuration - RicConfig config = ric.getConfig(); - this.rics.remove("ric1"); - ApplicationConfig.RicConfigUpdate update = - new ApplicationConfig.RicConfigUpdate(config, ApplicationConfig.RicConfigUpdate.Type.ADDED); - refreshConfigTask.handleUpdatedRicConfig(update).block(); - ric = this.rics.getRic("ric1"); - assertThat(ric.getSupportedPolicyTypes().size()).isEqualTo(1); - } + @Test + void testPersistencyPolicyTypes() throws ServiceException { + Ric ric = this.addRic("ric1"); + this.addPolicyType("type1", ric.id()); + PolicyTypes types = new PolicyTypes(this.applicationConfig); + assertThat(types.size()).isEqualTo(1); + } + + @Test + void testPersistencyService() throws ServiceException { + final String SERVICE = "serviceName"; + putService(SERVICE, 1234, HttpStatus.CREATED); + assertThat(this.services.size()).isEqualTo(1); + Service service = this.services.getService(SERVICE); + + Services servicesRestored = new Services(this.applicationConfig); + Service serviceRestored = servicesRestored.getService(SERVICE); + assertThat(servicesRestored.size()).isEqualTo(1); + assertThat(serviceRestored.getCallbackUrl()).isEqualTo(service.getCallbackUrl()); + assertThat(serviceRestored.getKeepAliveInterval()).isEqualTo(service.getKeepAliveInterval()); + + // check that the service can be deleted + this.services.remove(SERVICE); + servicesRestored = new Services(this.applicationConfig); + assertThat(servicesRestored.size()).isEqualTo(0); + } + + @Test + void testAddingRicFromConfiguration() throws Exception { + // Test adding the RIC from configuration + + final String RIC = "ric1"; + final String TYPE = "type123"; + PolicyTypes nearRtRicPolicyTypes = new PolicyTypes(this.applicationConfig); + nearRtRicPolicyTypes.put(createPolicyType(TYPE)); + this.a1ClientFactory.setPolicyTypes(nearRtRicPolicyTypes); + + putService("service"); + + RicConfig config = ricConfig(RIC, "me1"); + ApplicationConfig.RicConfigUpdate update = + new ApplicationConfig.RicConfigUpdate(config, ApplicationConfig.RicConfigUpdate.Type.ADDED); + refreshConfigTask.handleUpdatedRicConfig(update).block(); + waitForRicState(RIC, RicState.AVAILABLE); + + // Test that the type has been synched + Ric addedRic = this.rics.getRic(RIC); + assertThat(addedRic.getSupportedPolicyTypes().size()).isEqualTo(1); + assertThat(addedRic.getSupportedPolicyTypes().iterator().next().getId()).isEqualTo(TYPE); + + // Check that a service callback for the AVAILABLE RIC is invoked + RappSimulatorController.TestResults receivedCallbacks = rAppSimulator.getTestResults(); + assertThat(receivedCallbacks.getReceivedInfo().size()).isEqualTo(1); + ServiceCallbackInfo callbackInfo = receivedCallbacks.getReceivedInfo().get(0); + assertThat(callbackInfo.ricId).isEqualTo(RIC); + assertThat(callbackInfo.eventType).isEqualTo(ServiceCallbackInfo.EventType.AVAILABLE); } @Test @@ -887,20 +933,25 @@ class ApplicationTest { return addRic(ricId, null); } - private Ric addRic(String ricId, String managedElement) { - if (rics.get(ricId) != null) { - return rics.get(ricId); - } + private RicConfig ricConfig(String ricId, String managedElement) { List<String> mes = new ArrayList<>(); if (managedElement != null) { mes.add(managedElement); } - RicConfig conf = ImmutableRicConfig.builder() // + return ImmutableRicConfig.builder() // .ricId(ricId) // .baseUrl(ricId) // .managedElementIds(mes) // .controllerName("") // .build(); + } + + private Ric addRic(String ricId, String managedElement) { + if (rics.get(ricId) != null) { + return rics.get(ricId); + } + + RicConfig conf = ricConfig(ricId, managedElement); Ric ric = new Ric(conf); ric.setState(Ric.RicState.AVAILABLE); this.rics.put(ric); diff --git a/a1-policy-management/src/test/java/org/onap/ccsdk/oran/a1policymanagementservice/controllers/v2/RappSimulatorController.java b/a1-policy-management/src/test/java/org/onap/ccsdk/oran/a1policymanagementservice/controllers/v2/RappSimulatorController.java index 83a2d784..e5998346 100644 --- a/a1-policy-management/src/test/java/org/onap/ccsdk/oran/a1policymanagementservice/controllers/v2/RappSimulatorController.java +++ b/a1-policy-management/src/test/java/org/onap/ccsdk/oran/a1policymanagementservice/controllers/v2/RappSimulatorController.java @@ -75,7 +75,7 @@ public class RappSimulatorController { content = @Content(schema = @Schema(implementation = VoidResponse.class)))} // ) - public ResponseEntity<Object> jobStatusCallback( // + public ResponseEntity<Object> serviceCallback( // @RequestBody ServiceCallbackInfo body) { logger.info("R-App callback body: {}", gson.toJson(body)); this.testResults.receivedInfo.add(body); diff --git a/a1-policy-management/src/test/java/org/onap/ccsdk/oran/a1policymanagementservice/tasks/RefreshConfigTaskTest.java b/a1-policy-management/src/test/java/org/onap/ccsdk/oran/a1policymanagementservice/tasks/RefreshConfigTaskTest.java index c999214d..762d800f 100644 --- a/a1-policy-management/src/test/java/org/onap/ccsdk/oran/a1policymanagementservice/tasks/RefreshConfigTaskTest.java +++ b/a1-policy-management/src/test/java/org/onap/ccsdk/oran/a1policymanagementservice/tasks/RefreshConfigTaskTest.java @@ -121,7 +121,7 @@ class RefreshConfigTaskTest { boolean stubConfigFileExists) { RefreshConfigTask obj = spy(new RefreshConfigTask(configurationFileMock, appConfig, rics, policies, - new Services(), new PolicyTypes(appConfig), new A1ClientFactory(appConfig))); + new Services(appConfig), new PolicyTypes(appConfig), new A1ClientFactory(appConfig))); if (stubConfigFileExists) { when(configurationFileMock.readFile()).thenReturn(Optional.empty()); } diff --git a/a1-policy-management/src/test/java/org/onap/ccsdk/oran/a1policymanagementservice/tasks/RicSynchronizationTaskTest.java b/a1-policy-management/src/test/java/org/onap/ccsdk/oran/a1policymanagementservice/tasks/RicSynchronizationTaskTest.java index a2e7c75b..9bd5c502 100644 --- a/a1-policy-management/src/test/java/org/onap/ccsdk/oran/a1policymanagementservice/tasks/RicSynchronizationTaskTest.java +++ b/a1-policy-management/src/test/java/org/onap/ccsdk/oran/a1policymanagementservice/tasks/RicSynchronizationTaskTest.java @@ -110,7 +110,7 @@ class RicSynchronizationTaskTest { void init() { policyTypes = new PolicyTypes(appConfig); policies = new Policies(appConfig); - services = new Services(); + services = new Services(appConfig); rics = new Rics(); RIC_1.setState(RicState.UNAVAILABLE); RIC_1.clearSupportedPolicyTypes(); @@ -165,7 +165,6 @@ class RicSynchronizationTaskTest { verifyNoMoreInteractions(a1ClientMock); verify(synchronizerUnderTest).run(RIC_1); - verify(synchronizerUnderTest).notifyServices(any()); assertThat(policyTypes.size()).isEqualTo(1); assertThat(policies.size()).isZero(); diff --git a/a1-policy-management/src/test/java/org/onap/ccsdk/oran/a1policymanagementservice/tasks/ServiceSupervisionTest.java b/a1-policy-management/src/test/java/org/onap/ccsdk/oran/a1policymanagementservice/tasks/ServiceSupervisionTest.java index 4c0e96f5..294b220c 100644 --- a/a1-policy-management/src/test/java/org/onap/ccsdk/oran/a1policymanagementservice/tasks/ServiceSupervisionTest.java +++ b/a1-policy-management/src/test/java/org/onap/ccsdk/oran/a1policymanagementservice/tasks/ServiceSupervisionTest.java @@ -177,11 +177,10 @@ class ServiceSupervisionTest { } private void setUpRepositoryWithKeepAliveInterval(Duration keepAliveInterval) { - services = new Services(); + ApplicationConfig appConfig = new ApplicationConfig(); + services = new Services(appConfig); service = new Service(SERVICE_NAME, keepAliveInterval, "callbackUrl"); services.put(service); - - ApplicationConfig appConfig = new ApplicationConfig(); policies = new Policies(appConfig); policies.put(policy); } diff --git a/docs/offeredapis/swagger/pms-api.json b/docs/offeredapis/swagger/pms-api.json index d34e94be..95bc6580 100644 --- a/docs/offeredapis/swagger/pms-api.json +++ b/docs/offeredapis/swagger/pms-api.json @@ -1153,7 +1153,7 @@ "required": true }, "description": "The URL to this call is registerred at Service registration.", - "operationId": "jobStatusCallback", + "operationId": "serviceCallback", "responses": {"200": { "description": "OK", "content": {"application/json": {"schema": {"$ref": "#/components/schemas/void"}}} diff --git a/docs/offeredapis/swagger/pms-api.yaml b/docs/offeredapis/swagger/pms-api.yaml index b106d11c..b1444032 100644 --- a/docs/offeredapis/swagger/pms-api.yaml +++ b/docs/offeredapis/swagger/pms-api.yaml @@ -1033,7 +1033,7 @@ paths: - Callbacks summary: Callback for Near-RT RIC status description: The URL to this call is registerred at Service registration. - operationId: jobStatusCallback + operationId: serviceCallback requestBody: content: application/json: |