From 4277231cf397c2fbc12d4f5ca16d51c0f657bb4f Mon Sep 17 00:00:00 2001 From: Ravi Pendurty Date: Thu, 20 Aug 2020 12:48:17 +0200 Subject: Fix code smells based on SonarCloud report Bundles mountpoint-registrar and mountpoint-state-provider and also a Junit test case of aapter-manager devicemanager Issue-ID: CCSDK-2671 Signed-off-by: Ravi Pendurty Change-Id: I84324e6433415bdc001d735e17930c2eb63bb439 Signed-off-by: Ravi Pendurty --- .../test/TestMountpointNodeStateListenerImpl.java | 1 + .../test/TestMountpointStateProviderImpl.java | 11 +---------- 2 files changed, 2 insertions(+), 10 deletions(-) (limited to 'sdnr/wt/mountpoint-state-provider/provider/src/test/java') diff --git a/sdnr/wt/mountpoint-state-provider/provider/src/test/java/org/onap/ccsdk/features/sdnr/wt/mountpointstateprovider/test/TestMountpointNodeStateListenerImpl.java b/sdnr/wt/mountpoint-state-provider/provider/src/test/java/org/onap/ccsdk/features/sdnr/wt/mountpointstateprovider/test/TestMountpointNodeStateListenerImpl.java index c6a9d11e5..60841ec69 100644 --- a/sdnr/wt/mountpoint-state-provider/provider/src/test/java/org/onap/ccsdk/features/sdnr/wt/mountpointstateprovider/test/TestMountpointNodeStateListenerImpl.java +++ b/sdnr/wt/mountpoint-state-provider/provider/src/test/java/org/onap/ccsdk/features/sdnr/wt/mountpointstateprovider/test/TestMountpointNodeStateListenerImpl.java @@ -74,6 +74,7 @@ public class TestMountpointNodeStateListenerImpl { @Test public void testOnRemoved() { nodeStateListener.onRemoved(nNodeId); + assertNotEquals(mountpointStatePublisher.getStateObjects().size(), 0); } } diff --git a/sdnr/wt/mountpoint-state-provider/provider/src/test/java/org/onap/ccsdk/features/sdnr/wt/mountpointstateprovider/test/TestMountpointStateProviderImpl.java b/sdnr/wt/mountpoint-state-provider/provider/src/test/java/org/onap/ccsdk/features/sdnr/wt/mountpointstateprovider/test/TestMountpointStateProviderImpl.java index 1cebeb697..4e4ac3064 100644 --- a/sdnr/wt/mountpoint-state-provider/provider/src/test/java/org/onap/ccsdk/features/sdnr/wt/mountpointstateprovider/test/TestMountpointStateProviderImpl.java +++ b/sdnr/wt/mountpoint-state-provider/provider/src/test/java/org/onap/ccsdk/features/sdnr/wt/mountpointstateprovider/test/TestMountpointStateProviderImpl.java @@ -42,7 +42,7 @@ public class TestMountpointStateProviderImpl { @Test - public void before() throws InterruptedException, IOException { + public void test() throws InterruptedException, IOException { NetconfNodeStateService netconfNodeStateService = mock(NetconfNodeStateService.class); DeviceManagerServiceProvider serviceProvider = mock(DeviceManagerServiceProvider.class); VESCollectorService vesCollectorService = mock(VESCollectorService.class); @@ -57,13 +57,4 @@ public class TestMountpointStateProviderImpl { mountpointStateProvider.init(); } - /* @After - public void after() throws InterruptedException, IOException { - - try { - mountpointStateProvider.close(); - } catch (Exception e) { - System.out.println(e); - } - }*/ } -- cgit 1.2.3-korg