From 97662b28b1cfd66c167e6a13fbac1d1567780e10 Mon Sep 17 00:00:00 2001
From: surya-huawei <a.u.surya@huawei.com>
Date: Wed, 20 Sep 2017 11:53:06 +0530
Subject: Fix Sonar Issue in ccsdk/dashboard module

Few major issues
*Making anonymous inner class a lambda
This increases code readability
*Replace the type specification with the diamond operator
This reduces the verbosity of generics code

Issue-Id: CCSDK-87
Change-Id: Ia527040781af3a3d006486f3d73416f2f5e288cc
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
---
 .../dashboard/controller/CloudifyController.java   | 23 ++++------------------
 1 file changed, 4 insertions(+), 19 deletions(-)

diff --git a/oom-app-common/src/main/java/org/onap/oom/dashboard/controller/CloudifyController.java b/oom-app-common/src/main/java/org/onap/oom/dashboard/controller/CloudifyController.java
index 241a8cf..e9369e9 100644
--- a/oom-app-common/src/main/java/org/onap/oom/dashboard/controller/CloudifyController.java
+++ b/oom-app-common/src/main/java/org/onap/oom/dashboard/controller/CloudifyController.java
@@ -86,32 +86,17 @@ public class CloudifyController extends DashboardRestrictedBaseController {
 	/**
 	 * Supports sorting blueprints by ID
 	 */
-	private static Comparator<CloudifyBlueprint> blueprintComparator = new Comparator<CloudifyBlueprint>() {
-		@Override
-		public int compare(CloudifyBlueprint o1, CloudifyBlueprint o2) {
-			return o1.id.compareTo(o2.id);
-		}
-	};
+	private static Comparator<CloudifyBlueprint> blueprintComparator = (o1, o2) -> o1.id.compareTo(o2.id);
 
 	/**
 	 * Supports sorting deployments by ID
 	 */
-	private static Comparator<CloudifyDeployment> deploymentComparator = new Comparator<CloudifyDeployment>() {
-		@Override
-		public int compare(CloudifyDeployment o1, CloudifyDeployment o2) {
-			return o1.id.compareTo(o2.id);
-		}
-	};
+	private static Comparator<CloudifyDeployment> deploymentComparator = (o1, o2) -> o1.id.compareTo(o2.id);
 
 	/**
 	 * Supports sorting executions by ID
 	 */
-	private static Comparator<CloudifyExecution> executionComparator = new Comparator<CloudifyExecution>() {
-		@Override
-		public int compare(CloudifyExecution o1, CloudifyExecution o2) {
-			return o1.id.compareTo(o2.id);
-		}
-	};
+	private static Comparator<CloudifyExecution> executionComparator = (o1, o2) -> o1.id.compareTo(o2.id);
 
 	/**
 	 * Gets one page of objects and supporting information via the REST client.
@@ -497,7 +482,7 @@ public class CloudifyController extends DashboardRestrictedBaseController {
 		logger.setRequestBasedDefaultsIntoGlobalLoggingContext(request, APP_NAME);
 		ECTransportModel result = null;
 		try {
-			List<CloudifyExecution> itemList = new ArrayList<CloudifyExecution>();
+			List<CloudifyExecution> itemList = new ArrayList<>();
 			IControllerRestClient restClient = getControllerRestClient(request);
 			List<String> depIds = new ArrayList<>();
 			if (deployment_id == null) {
-- 
cgit 1.2.3-korg