From c15af9a019ae786bc6970fa1184361c1be96693a Mon Sep 17 00:00:00 2001 From: Eliezio Oliveira Date: Sat, 13 Jul 2019 19:33:24 +0100 Subject: Fixed bugs/vulnerabilities reported by SonarQube Change-Id: Idc4be0d050d27fd419915210167b044b90fa2f0a Issue-ID: CCSDK-1483 Signed-off-by: Eliezio Oliveira --- .../filters/ApplicationLoggingFilter.java | 2 +- .../service/common/SwaggerGenerator.java | 13 +++++-------- 2 files changed, 6 insertions(+), 9 deletions(-) (limited to 'ms/controllerblueprints') diff --git a/ms/controllerblueprints/application/src/main/java/org/onap/ccsdk/cds/controllerblueprints/filters/ApplicationLoggingFilter.java b/ms/controllerblueprints/application/src/main/java/org/onap/ccsdk/cds/controllerblueprints/filters/ApplicationLoggingFilter.java index 60837e8a7..331a44d83 100644 --- a/ms/controllerblueprints/application/src/main/java/org/onap/ccsdk/cds/controllerblueprints/filters/ApplicationLoggingFilter.java +++ b/ms/controllerblueprints/application/src/main/java/org/onap/ccsdk/cds/controllerblueprints/filters/ApplicationLoggingFilter.java @@ -79,7 +79,7 @@ public class ApplicationLoggingFilter implements WebFilter { header.add(BluePrintConstants.RESPONSE_HEADER_PATCH_VERSION, tokens[2]); header.add(BluePrintConstants.RESPONSE_HEADER_LATEST_VERSION, appVersion); } catch (Exception e) { - e.printStackTrace(); + log.error("*** Error ***", e); } return webFilterChain.filter(serverWebExchange); diff --git a/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/cds/controllerblueprints/service/common/SwaggerGenerator.java b/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/cds/controllerblueprints/service/common/SwaggerGenerator.java index abf774981..38216a616 100644 --- a/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/cds/controllerblueprints/service/common/SwaggerGenerator.java +++ b/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/cds/controllerblueprints/service/common/SwaggerGenerator.java @@ -155,19 +155,16 @@ public class SwaggerGenerator { defProperty = new StringProperty(); } } else if (BluePrintTypes.validCollectionTypes().contains(propertyDefinition.getType())) { - ArrayProperty arrayProperty = new ArrayProperty(); + Optional innerType = Optional.empty(); if (propertyDefinition.getEntrySchema() != null) { String entrySchema = propertyDefinition.getEntrySchema().getType(); if (!BluePrintTypes.validPrimitiveTypes().contains(entrySchema)) { - Property innerType = new RefProperty("#/definitions/" + entrySchema); - arrayProperty.setItems(innerType); - } else { - Property innerType = new StringProperty(); - arrayProperty.setItems(innerType); + innerType = Optional.of(new RefProperty("#/definitions/" + entrySchema)); } - defProperty = arrayProperty; } - + ArrayProperty arrayProperty = new ArrayProperty(); + arrayProperty.setItems(innerType.orElseGet(StringProperty::new)); + defProperty = arrayProperty; } else { defProperty = new RefProperty("#/definitions/" + propertyDefinition.getType()); } -- cgit 1.2.3-korg