From 26f7862d17e3668b5e258d8370458699db3968b9 Mon Sep 17 00:00:00 2001 From: ezhil Date: Wed, 26 Dec 2018 16:38:07 +0530 Subject: Fixed sonar issue in ExternalKeyValidator Fixed major sonar issue Issue-ID: CCSDK-690 Change-Id: I17abdb751f1a384bd0c63e5b336186eaad945783 Signed-off-by: ezhil --- .../onap/ccsdk/apps/ms/neng/core/validator/ExternalKeyValidator.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/validator/ExternalKeyValidator.java b/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/validator/ExternalKeyValidator.java index 4b7ec79b..c17158c0 100644 --- a/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/validator/ExternalKeyValidator.java +++ b/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/validator/ExternalKeyValidator.java @@ -4,6 +4,8 @@ * ================================================================================ * Copyright (C) 2018 AT&T Intellectual Property. All rights reserved. * ================================================================================ + * Modifications Copyright (C) 2018 IBM. + * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at @@ -36,7 +38,7 @@ public class ExternalKeyValidator { * Tells if the given external ID is present in the DB. */ public boolean isPresent(String externalId) { - if (genNameRepo.findByExternalId(externalId).size() > 0 || genNameRepo.findByExternalId(externalId).isEmpty() ) { + if (!genNameRepo.findByExternalId(externalId).isEmpty() ) { return true; } return false; -- cgit 1.2.3-korg