summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorezhil <ezhrajam@in.ibm.com>2018-12-26 16:38:07 +0530
committerezhil <ezhrajam@in.ibm.com>2018-12-26 16:38:20 +0530
commit26f7862d17e3668b5e258d8370458699db3968b9 (patch)
tree1c71e8648c44ea66ab0de9b05d58bc1d6d13e4c4
parentbefd14604e8f19a517f79c0f8b6ff2f4b418d747 (diff)
Fixed sonar issue in ExternalKeyValidator
Fixed major sonar issue Issue-ID: CCSDK-690 Change-Id: I17abdb751f1a384bd0c63e5b336186eaad945783 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
-rw-r--r--ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/validator/ExternalKeyValidator.java4
1 files changed, 3 insertions, 1 deletions
diff --git a/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/validator/ExternalKeyValidator.java b/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/validator/ExternalKeyValidator.java
index 4b7ec79b..c17158c0 100644
--- a/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/validator/ExternalKeyValidator.java
+++ b/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/validator/ExternalKeyValidator.java
@@ -4,6 +4,8 @@
* ================================================================================
* Copyright (C) 2018 AT&T Intellectual Property. All rights reserved.
* ================================================================================
+ * Modifications Copyright (C) 2018 IBM.
+ * ================================================================================
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
@@ -36,7 +38,7 @@ public class ExternalKeyValidator {
* Tells if the given external ID is present in the DB.
*/
public boolean isPresent(String externalId) {
- if (genNameRepo.findByExternalId(externalId).size() > 0 || genNameRepo.findByExternalId(externalId).isEmpty() ) {
+ if (!genNameRepo.findByExternalId(externalId).isEmpty() ) {
return true;
}
return false;