From d37a45ab352084738b3f95cb64cc83d4e1484d0b Mon Sep 17 00:00:00 2001 From: Patrick Brady Date: Thu, 14 Nov 2019 14:17:04 -0800 Subject: Add additional error messages to dmaap service Add error checking and logging if required properties are not present. Change-Id: I270a7a088e36de603b89133e9ccb22f206e931e4 Signed-off-by: Patrick Brady Issue-ID: APPC-1744 --- .../onap/appc/services/dmaapService/PublishService.java | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'services') diff --git a/services/appc-dmaap-service/appc-dmaap-event-service/src/main/java/org/onap/appc/services/dmaapService/PublishService.java b/services/appc-dmaap-service/appc-dmaap-event-service/src/main/java/org/onap/appc/services/dmaapService/PublishService.java index 1e1b9e7f8..cc20539f4 100644 --- a/services/appc-dmaap-service/appc-dmaap-event-service/src/main/java/org/onap/appc/services/dmaapService/PublishService.java +++ b/services/appc-dmaap-service/appc-dmaap-event-service/src/main/java/org/onap/appc/services/dmaapService/PublishService.java @@ -30,6 +30,10 @@ import org.onap.appc.adapter.factory.DmaapMessageAdapterFactoryImpl; import org.onap.appc.configuration.Configuration; import org.onap.appc.configuration.ConfigurationFactory; import org.springframework.stereotype.Service; + +import com.att.eelf.configuration.EELFLogger; +import com.att.eelf.configuration.EELFManager; + import org.onap.appc.adapter.message.MessageAdapterFactory; import org.onap.appc.adapter.message.Producer; import org.onap.appc.adapter.messaging.dmaap.http.HttpDmaapProducerImpl; @@ -37,6 +41,8 @@ import org.onap.appc.adapter.messaging.dmaap.http.HttpDmaapProducerImpl; @Service public class PublishService { + private static final EELFLogger LOG = EELFManager.getInstance().getLogger(PublishService.class); + private Map producers; private MessageAdapterFactory factory; Configuration configuration; @@ -101,6 +107,14 @@ public class PublishService { pool.add(name); } } + if(pool.isEmpty()) { + LOG.error("There are no dmaap server pools. Check the property " + key + ".poolMembers"); + return null; + } + if(writeTopic == null || writeTopic.isEmpty()) { + LOG.error("There is no write topic defined in the message request or in the properties file"); + return null; + } return factory.createProducer(pool, writeTopic, apiKey, apiSecret); } return null; -- cgit 1.2.3-korg