From 06bfa9f289b1960a3ac692b2e58dac3da6abb968 Mon Sep 17 00:00:00 2001 From: Rupinder Date: Wed, 13 May 2020 14:02:09 +0530 Subject: lower code smells Issue-ID: APPC-1859 Change-Id: If95047a9f6b568c8ef4796d48572c23a36ac36fc Signed-off-by: Rupinder --- appc-oam/appc-oam-bundle/src/main/java/org/onap/appc/oam/AppcOam.java | 2 +- .../src/main/java/org/onap/appc/oam/util/BundleHelper.java | 4 ++-- .../src/main/java/org/onap/appc/oam/util/ConfigurationHelper.java | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) (limited to 'appc-oam/appc-oam-bundle/src') diff --git a/appc-oam/appc-oam-bundle/src/main/java/org/onap/appc/oam/AppcOam.java b/appc-oam/appc-oam-bundle/src/main/java/org/onap/appc/oam/AppcOam.java index c41abb22d..50c6d49c7 100644 --- a/appc-oam/appc-oam-bundle/src/main/java/org/onap/appc/oam/AppcOam.java +++ b/appc-oam/appc-oam-bundle/src/main/java/org/onap/appc/oam/AppcOam.java @@ -91,7 +91,7 @@ public class AppcOam implements AutoCloseable, AppcOamService { /** * Invalid state message format with fliexible operation, appc name and state values */ - public final static String INVALID_STATE_MESSAGE_FORMAT = "%s API is not allowed when %s is in the %s state."; + public static final String INVALID_STATE_MESSAGE_FORMAT = "%s API is not allowed when %s is in the %s state."; private final EELFLogger logger = EELFManager.getInstance().getLogger(AppcOam.class); diff --git a/appc-oam/appc-oam-bundle/src/main/java/org/onap/appc/oam/util/BundleHelper.java b/appc-oam/appc-oam-bundle/src/main/java/org/onap/appc/oam/util/BundleHelper.java index 7639c4075..9559b54aa 100644 --- a/appc-oam/appc-oam-bundle/src/main/java/org/onap/appc/oam/util/BundleHelper.java +++ b/appc-oam/appc-oam-bundle/src/main/java/org/onap/appc/oam/util/BundleHelper.java @@ -44,8 +44,8 @@ import java.util.concurrent.Future; * Utility class provides general bundle operational helps. */ public class BundleHelper { - private final static String PROP_BUNDLE_TO_STOP = "appc.OAM.ToStop.properties"; - private final static String PROP_BUNDLES_TO_NOT_STOP = "appc.OAM.ToNotStop.properties"; + private static final String PROP_BUNDLE_TO_STOP = "appc.OAM.ToStop.properties"; + private static final String PROP_BUNDLES_TO_NOT_STOP = "appc.OAM.ToNotStop.properties"; private final EELFLogger logger; private final StateHelper stateHelper; diff --git a/appc-oam/appc-oam-bundle/src/main/java/org/onap/appc/oam/util/ConfigurationHelper.java b/appc-oam/appc-oam-bundle/src/main/java/org/onap/appc/oam/util/ConfigurationHelper.java index 63cff68db..d6f27195f 100644 --- a/appc-oam/appc-oam-bundle/src/main/java/org/onap/appc/oam/util/ConfigurationHelper.java +++ b/appc-oam/appc-oam-bundle/src/main/java/org/onap/appc/oam/util/ConfigurationHelper.java @@ -35,8 +35,8 @@ import java.util.concurrent.TimeUnit; * Utility class provides general configuration helps */ public class ConfigurationHelper { - final static String PROP_KEY_APPC_NAME = Constants.PROPERTY_APPLICATION_NAME; - final static String PROP_KEY_METRIC_STATE = "metric.enabled"; + static final String PROP_KEY_APPC_NAME = Constants.PROPERTY_APPLICATION_NAME; + static final String PROP_KEY_METRIC_STATE = "metric.enabled"; private final String OAM_OPERATION_TIMEOUT_SECOND = "appc.OAM.api.timeout"; /** Default operation timeout set to 1 minute */ private final int DEFAULT_OAM_OPERATION_TIMEOUT = 60; -- cgit 1.2.3-korg