From 19bb17c4b16ee955cdec6db9ddc2af25845df062 Mon Sep 17 00:00:00 2001 From: Joss Armstrong Date: Thu, 14 Feb 2019 13:38:23 +0000 Subject: Test coverage in XInterfaceService Increased coverage from 68% to 100% Issue-ID: APPC-1436 Change-Id: If9f1670ba9955325bf938d7edf3d7d67bb48088c Signed-off-by: Joss Armstrong --- .../appc/design/xinterface/XInterfaceService.java | 53 ++++++++++++---------- 1 file changed, 28 insertions(+), 25 deletions(-) (limited to 'appc-inbound/appc-design-services/provider/src/main/java') diff --git a/appc-inbound/appc-design-services/provider/src/main/java/org/onap/appc/design/xinterface/XInterfaceService.java b/appc-inbound/appc-design-services/provider/src/main/java/org/onap/appc/design/xinterface/XInterfaceService.java index 42f13243d..4e93af149 100644 --- a/appc-inbound/appc-design-services/provider/src/main/java/org/onap/appc/design/xinterface/XInterfaceService.java +++ b/appc-inbound/appc-design-services/provider/src/main/java/org/onap/appc/design/xinterface/XInterfaceService.java @@ -31,31 +31,34 @@ import com.att.eelf.configuration.EELFManager; import com.google.common.base.Strings; public class XInterfaceService { - - private final EELFLogger log = EELFManager.getInstance().getLogger(XInterfaceService.class); - - public static XInterfaceService getInstance() { - return new XInterfaceService(); - } - - public String execute(String action, String payload) throws Exception { - // File targetFile = new File("/tmp/" + action + "-response.txt" ); - String interfaceResponse = null; - try { - if (Strings.isNullOrEmpty(payload)) - throw new Exception("Payload is null or empty.."); - if (DesignServiceConstants.GETINSTARDATA.equalsIgnoreCase(action)) { - XResponseProcessor xResponseProcessor = new XResponseProcessor(); - interfaceResponse = - xResponseProcessor.parseResponse(payload, DesignServiceConstants.GETINSTARDATA); - } else { - throw new Exception("No Such Action, Please enter valid Action"); - } - } catch (Exception e) { - e.printStackTrace(); - throw e; + + private final EELFLogger log = EELFManager.getInstance().getLogger(XInterfaceService.class); + + public static XInterfaceService getInstance() { + return new XInterfaceService(); + } + + public String execute(String action, String payload) throws Exception { + String interfaceResponse = null; + try { + if (Strings.isNullOrEmpty(payload)) + throw new Exception("Payload is null or empty.."); + if (DesignServiceConstants.GETINSTARDATA.equalsIgnoreCase(action)) { + XResponseProcessor xResponseProcessor = getXResponseProcessor(); + interfaceResponse = + xResponseProcessor.parseResponse(payload, DesignServiceConstants.GETINSTARDATA); + } else { + throw new Exception("No Such Action, Please enter valid Action"); + } + } catch (Exception e) { + log.error(e.getMessage()); + throw e; + } + return interfaceResponse; + } + + protected XResponseProcessor getXResponseProcessor() { + return new XResponseProcessor(); } - return interfaceResponse; - } } -- cgit 1.2.3-korg