From f74c992c1ad8471303df62066ab5f9d778825e30 Mon Sep 17 00:00:00 2001 From: Jakub Dudycz Date: Fri, 16 Mar 2018 16:44:51 +0100 Subject: InputBody and OutputBody unit tests Improved code coverage. Change-Id: I8b083f3281f0057d14cdfa9ae3c47eb3da99614e Issue-ID: APPC-745 Signed-off-by: Jakub Dudycz --- .../onap/appc/listener/LCM/model/InputBody.java | 25 +++++++++-------- .../onap/appc/listener/LCM/model/OutputBody.java | 32 +++++++++++----------- .../appc/listener/LCM/model/ResponseStatus.java | 16 +++++------ 3 files changed, 37 insertions(+), 36 deletions(-) (limited to 'appc-event-listener/appc-event-listener-bundle/src/main/java/org') diff --git a/appc-event-listener/appc-event-listener-bundle/src/main/java/org/onap/appc/listener/LCM/model/InputBody.java b/appc-event-listener/appc-event-listener-bundle/src/main/java/org/onap/appc/listener/LCM/model/InputBody.java index 85aed42d8..d5f157d8d 100644 --- a/appc-event-listener/appc-event-listener-bundle/src/main/java/org/onap/appc/listener/LCM/model/InputBody.java +++ b/appc-event-listener/appc-event-listener-bundle/src/main/java/org/onap/appc/listener/LCM/model/InputBody.java @@ -50,34 +50,35 @@ public class InputBody { return payload; } - public void setPayload(Object payload) { - this.payload = payload; + public String getAction() { + return action; } + + public ActionIdentifiers getActionIdentifiers() { + return actionIdentifiers; + } + + public CommonHeader getCommonHeader() { + return commonHeader; + } + @JsonIgnore public void setPayloadAsString(String payload) { this.payload = payload; } - public String getAction() { - return action; + public void setPayload(Object payload) { + this.payload = payload; } public void setAction(String action) { this.action = action; } - public ActionIdentifiers getActionIdentifiers() { - return actionIdentifiers; - } - public void setActionIdentifiers(ActionIdentifiers actionIdentifiers) { this.actionIdentifiers = actionIdentifiers; } - public CommonHeader getCommonHeader() { - return commonHeader; - } - public void setCommonHeader(CommonHeader commonHeader) { this.commonHeader = commonHeader; } diff --git a/appc-event-listener/appc-event-listener-bundle/src/main/java/org/onap/appc/listener/LCM/model/OutputBody.java b/appc-event-listener/appc-event-listener-bundle/src/main/java/org/onap/appc/listener/LCM/model/OutputBody.java index 11714e8fb..54eab7914 100644 --- a/appc-event-listener/appc-event-listener-bundle/src/main/java/org/onap/appc/listener/LCM/model/OutputBody.java +++ b/appc-event-listener/appc-event-listener-bundle/src/main/java/org/onap/appc/listener/LCM/model/OutputBody.java @@ -32,7 +32,6 @@ import org.onap.appc.listener.util.Mapper; /** * This class represents a message being sent out to DMaaP by APPC to update listeners on the status of a request - * */ @JsonSerialize(include = JsonSerialize.Inclusion.NON_NULL) @JsonIgnoreProperties(ignoreUnknown = true) @@ -53,38 +52,27 @@ public class OutputBody { public OutputBody() { } + public OutputBody(InputBody msg) { + this.header = new CommonHeader(msg.getCommonHeader()); + } + public JSONObject toResponse() { return Mapper.toJsonObject(this); } - public OutputBody(InputBody msg) { - this.header = new CommonHeader(msg.getCommonHeader()); - } - public String getLocked() { return locked; } - public void setLocked(String locked) { - this.locked = locked; - } public String getPayload() { return payload; } - public void setPayload(String payload) { - this.payload = payload; - } - public CommonHeader getHeader() { return header; } - public void setHeader(CommonHeader header) { - this.header = header; - } - public ResponseStatus getStatus() { return status; } @@ -93,6 +81,18 @@ public class OutputBody { this.status = status; } + public void setLocked(String locked) { + this.locked = locked; + } + + public void setHeader(CommonHeader header) { + this.header = header; + } + + public void setPayload(String payload) { + this.payload = payload; + } + @Override public String toString() { return String.format("%s - %s(%s)", getHeader().getRequestID(), getStatus().getCode(), getStatus().getValue()); diff --git a/appc-event-listener/appc-event-listener-bundle/src/main/java/org/onap/appc/listener/LCM/model/ResponseStatus.java b/appc-event-listener/appc-event-listener-bundle/src/main/java/org/onap/appc/listener/LCM/model/ResponseStatus.java index 114b97b35..5c00295e4 100644 --- a/appc-event-listener/appc-event-listener-bundle/src/main/java/org/onap/appc/listener/LCM/model/ResponseStatus.java +++ b/appc-event-listener/appc-event-listener-bundle/src/main/java/org/onap/appc/listener/LCM/model/ResponseStatus.java @@ -32,6 +32,7 @@ import com.fasterxml.jackson.databind.annotation.JsonSerialize; @JsonSerialize(include = JsonSerialize.Inclusion.NON_NULL) @JsonIgnoreProperties(ignoreUnknown = true) public class ResponseStatus { + @JsonProperty("code") private Integer code; @JsonProperty("message") @@ -49,25 +50,24 @@ public class ResponseStatus { return code; } - public void setCode(Integer code) { - code = code; - } public String getValue() { return value; } - + public void setCode(Integer code) { + this.code = code; + } public void setValue(String value) { - value = value; + this.value = value; } @Override public String toString() { return "ResponseStatus{" + - "code=" + code + - ", value='" + value + '\'' + - '}'; + "code=" + code + + ", value='" + value + '\'' + + '}'; } } -- cgit 1.2.3-korg