From ec248ffb74f1c038fdd6c7a77411f628ef51366f Mon Sep 17 00:00:00 2001 From: Krishnajinka Date: Fri, 6 Jul 2018 17:28:54 +0900 Subject: null ptr check rework based on review comments Issue-ID: APPC-1047 Change-Id: Ia87707535dc5825d18a6c35fdae416064dcb8c14 Signed-off-by: Krishnajinka --- .../onap/appc/dg/dependencymanager/impl/DependencyManagerImpl.java | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'appc-dg/appc-dg-shared/appc-dg-dependency-model') diff --git a/appc-dg/appc-dg-shared/appc-dg-dependency-model/src/main/java/org/onap/appc/dg/dependencymanager/impl/DependencyManagerImpl.java b/appc-dg/appc-dg-shared/appc-dg-dependency-model/src/main/java/org/onap/appc/dg/dependencymanager/impl/DependencyManagerImpl.java index 82891b02d..ecd3c0305 100644 --- a/appc-dg/appc-dg-shared/appc-dg-dependency-model/src/main/java/org/onap/appc/dg/dependencymanager/impl/DependencyManagerImpl.java +++ b/appc-dg/appc-dg-shared/appc-dg-dependency-model/src/main/java/org/onap/appc/dg/dependencymanager/impl/DependencyManagerImpl.java @@ -55,6 +55,11 @@ public class DependencyManagerImpl implements DependencyManager { if(dependencyModel == null){ logger.debug("Dependency model not found in cache, creating strategy for reading it"); DependencyType strategy = getStrategy(dependencyType); + // Throw exception if strategy could not be created because it is required + // to retrieve the vnfc dependency model later + if (strategy == null) { + throw new NullPointerException("Strategy is null. Failed to retrieve Vnfc Dependency Model"); + } dependencyModel = strategy.getVnfcDependencyModel(modelIdentifier); } if (logger.isTraceEnabled()) { -- cgit 1.2.3-korg