From 312e9f071ef0a8b3482278e8909f66f4c986ba89 Mon Sep 17 00:00:00 2001
From: Jakub Dudycz <jakub.dudycz@nokia.com>
Date: Mon, 26 Feb 2018 12:38:53 +0100
Subject: appc-config-generator-provider sonar fixes part 2

Sonar fixes in whole module

Change-Id: I55856a6ce73a73098dadb2c5b9428437349ed8a8
Issue-ID: APPC-671
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
---
 .../sdnc/config/generator/tool/CheckDataTool.java  | 23 +++++++++++-----------
 1 file changed, 11 insertions(+), 12 deletions(-)

(limited to 'appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/CheckDataTool.java')

diff --git a/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/CheckDataTool.java b/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/CheckDataTool.java
index 4488e0be8..3895aa47f 100644
--- a/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/CheckDataTool.java
+++ b/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/tool/CheckDataTool.java
@@ -24,6 +24,8 @@
 
 package org.onap.sdnc.config.generator.tool;
 
+import com.att.eelf.configuration.EELFLogger;
+import com.att.eelf.configuration.EELFManager;
 import java.io.StringReader;
 import javax.xml.parsers.DocumentBuilder;
 import javax.xml.parsers.DocumentBuilderFactory;
@@ -31,11 +33,15 @@ import org.codehaus.jettison.json.JSONArray;
 import org.codehaus.jettison.json.JSONException;
 import org.codehaus.jettison.json.JSONObject;
 import org.onap.sdnc.config.generator.ConfigGeneratorConstant;
-import org.w3c.dom.Document;
 import org.xml.sax.InputSource;
 
 public class CheckDataTool {
 
+    private static final EELFLogger logger = EELFManager.getInstance().getLogger(CheckDataTool.class);
+    private static final String STR_INPUT_DATA = "Input data: \n";
+
+    private CheckDataTool() {}
+
     public static String checkData(String data) {
         boolean isJSON = isJSON(data);
         if (isJSON) {
@@ -54,33 +60,26 @@ public class CheckDataTool {
         try {
             new JSONObject(data);
         } catch (JSONException ex) {
+            logger.error(STR_INPUT_DATA + data + "\n is not json object", ex);
             try {
                 new JSONArray(data);
             } catch (JSONException ex1) {
+                logger.error(STR_INPUT_DATA + data + "\n is not json array", ex1);
                 return false;
             }
         }
         return true;
-
-        // try {
-        // final ObjectMapper mapper = new ObjectMapper();
-        // mapper.readTree(data);
-        // return true;
-        // } catch (IOException e) {
-        // return false;
-        // }
     }
 
     public static boolean isXML(String data) {
         try {
             DocumentBuilderFactory dbFactory = DocumentBuilderFactory.newInstance();
             DocumentBuilder dBuilder = dbFactory.newDocumentBuilder();
-            Document doc = dBuilder.parse(new InputSource(new StringReader(data)));
+            dBuilder.parse(new InputSource(new StringReader(data)));
             return true;
         } catch (Exception ex) {
+            logger.error(STR_INPUT_DATA + data + "\n is not xml document", ex);
             return false;
         }
-
     }
-
 }
-- 
cgit 1.2.3-korg