From 4899134f1c9d137b2b247991f64ba5d98352e8ba Mon Sep 17 00:00:00 2001 From: Arundathi Patil Date: Mon, 3 Dec 2018 15:28:33 +0530 Subject: Sonar Fix: AAIResourceNode.java Fixed sonar issues/code-smells across this file. Issue-ID: APPC-1265 Change-Id: Id0339b89f05ba3d55d6b01a0c885fabcadcd86da Signed-off-by: Arundathi Patil --- .../main/java/org/onap/appc/aai/client/node/AAIResourceNode.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/appc-outbound/appc-aai-client/provider/src/main/java/org/onap/appc/aai/client/node/AAIResourceNode.java b/appc-outbound/appc-aai-client/provider/src/main/java/org/onap/appc/aai/client/node/AAIResourceNode.java index 853565fad..e32cc94ea 100644 --- a/appc-outbound/appc-aai-client/provider/src/main/java/org/onap/appc/aai/client/node/AAIResourceNode.java +++ b/appc-outbound/appc-aai-client/provider/src/main/java/org/onap/appc/aai/client/node/AAIResourceNode.java @@ -84,15 +84,14 @@ public class AAIResourceNode implements SvcLogicJavaPlugin { log.debug("Cloud Owner" + cloudOwnerValue); log.debug("CloudRegionId" + cloudOwnerValue); - SvcLogicContext cloudCtx = new SvcLogicContext(); Map paramsCloud = new HashMap(); paramsCloud.put(AppcAaiClientConstant.INPUT_PARAM_RESPONSE_PREFIX, inParams.get(AppcAaiClientConstant.INPUT_PARAM_RESPONSE_PREFIX)); if(StringUtils.isNotBlank(cloudOwnerValue)&&StringUtils.isNotBlank(cloudRegionValue)) { - paramsCloud.put("cloudOwner", cloudOwnerValue); - paramsCloud.put("cloudRegionId", cloudRegionValue); + paramsCloud.put(PARAM_CLOUD_OWNER, cloudOwnerValue); + paramsCloud.put(PARAM_CLOUD_REGION_ID, cloudRegionValue); aai.getIdentityUrl(paramsCloud, ctx); } @@ -511,7 +510,7 @@ public class AAIResourceNode implements SvcLogicJavaPlugin { return params; } - public void getVfModuleModelInfo(Map inParams, SvcLogicContext ctx) throws SvcLogicException { + public void getVfModuleModelInfo(Map inParams, SvcLogicContext ctx) { log.info("vfModuleInfo()::Retrieving vf-module information :" + inParams.toString()); String responsePrefix = inParams.get(AppcAaiClientConstant.INPUT_PARAM_RESPONSE_PREFIX); try { @@ -571,7 +570,7 @@ public class AAIResourceNode implements SvcLogicJavaPlugin { } - public void getFormattedValue(Map inParams, SvcLogicContext ctx) throws SvcLogicException { + public void getFormattedValue(Map inParams, SvcLogicContext ctx) { log.info("getFormattedValue()::Formatting values :" + inParams.toString()); String responsePrefix = inParams.get(AppcAaiClientConstant.INPUT_PARAM_RESPONSE_PREFIX); try { -- cgit 1.2.3-korg