aboutsummaryrefslogtreecommitdiffstats
path: root/appc-adapters
AgeCommit message (Collapse)AuthorFilesLines
2018-03-26Coverage testamshegokar2-0/+156
Unit Test Coverage for: 1) NetconfConnectionDetails.java 2) NetconfClientType.java Sonar-Link: https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-netconf-adapter-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fnetconf Change-Id: I161d7bfe5e780c7c686ae014d87208e3da36b3cd Issue-ID: APPC-780 Signed-off-by: amshegokar <AS00500801@techmahindra.com>
2018-03-26Test Coverageamshegokar2-0/+128
Unit test for:org/onap/appc/adapter/netconf/exception classes 1. DataAccessException.java 2. NetconfDAOException.java Sonar-Link: https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-netconf-adapter-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fnetconf%2Fexception Change-Id: I9b02c0ddc01b4327135ccc754a6466105b1e18ff Issue-ID: APPC-779 Signed-off-by: amshegokar <AS00500801@techmahindra.com>
2018-03-23ChefAdapterImpl cleanupMichal Kabaj2-301/+24
- Switched usage of RequestContext class for wrapping the SvcLogicContext to using the SvcLogicContext directly - Removed unused RequestContext class Change-Id: I7376e3d6f5602887cf5a25f1f90ff45805c620b2 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-23Unit test coverageamshegokar1-0/+34
Unit test coverage for Constants.java Sonar-Link: https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-iaas-adapter-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Futils%2FConstants.java Change-Id: Ied122a1838111897079243f0e444a9eef1b2f162 Issue-ID: APPC-778 Signed-off-by: amshegokar <AS00500801@techmahindra.com>
2018-03-23ChefAdapterImpl junitsMichal Kabaj1-7/+110
Add new JUnits to ChefAdapterImplVNFCOperationsTest Change-Id: I243b2f46fdb75ad3c689b7875361fb9a654eaf60 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-22Corrected condition to pick regionBalaji, Ramya (rb111y)1-1/+1
Fixed condition so that region can be determined correctly Issue-ID: APPC-776 Change-Id: Iaf57a4face50d99a56cd4b85c0a318d34632a1e8 Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
2018-03-22ChefAdapterImpl junitsMichal Kabaj2-29/+209
- Added new Junit class ChefAdapterImplVNFCOperationsTest - Added unit tests for method vnfcEnvironment - Small refactor to for exception handling in vnfcEnvironment method to improve readability and avoid catching and rethrowing same exception Change-Id: I58a43390ff45598f6d17da48eed3620667008cb7 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-22Bugfixes for error handling while attaching volumeModaboina, Kusumakumari (km583p)1-29/+88
Change-Id: I103709186eff4fc9e42038b2e1113b010b822528 Issue-ID: APPC-761 Signed-off-by: Modaboina, Kusumakumari (km583p) <km583p@us.att.com>
2018-03-21bugfix for error handling while detaching volumesModaboina, Kusumakumari (km583p)3-487/+533
Change-Id: I96f7d017a63b0741d87666f4608356567932ff77 Issue-ID: APPC-762 Signed-off-by: Modaboina, Kusumakumari (km583p) <km583p@us.att.com>
2018-03-20ChefAdapterImpl JunitsMichal Kabaj2-20/+138
- Added new Unit tests for ChefAdapterImpl checkPushJob method to class ChefAdapterImplJobPusherTest - Added param check in implementation method - Small refactor of nested conditions for improved readability Change-Id: Id65b897535874eea6aafda66b7ac227832446cf4 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-20Unit test for MessageDestination.javashubhada1-0/+39
Unit test for MessageDestination.java Sonar-Link: https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-message-adapter-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fmessage%2FMessageDestination.java Change-Id: I17032a622571ce6ed6e6454967edabc2f2ef2d33 Issue-ID: APPC-764 Signed-off-by: shubhada <SV00449682@techmahindra.com>
2018-03-19Unit tests for appc-ssh-adapter-api classesshubhada2-0/+110
Unit Tests for: 1. SshDataAccessException.java 2. SshException.java Sonar-Link: https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-ssh-adapter-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fssh Change-Id: I7c927a5319143e5df051d008f8f5dbb546699b99 Issue-ID: APPC-759 Signed-off-by: shubhada <SV00449682@techmahindra.com>
2018-03-16ChefAdapterImpl JunitsMichal Kabaj3-11/+135
-Added new Unit tests for ChefAdapterImpl pushJob method -Added new Junit class ChefAdapterImplJobPusher -Some minor construction refactor in other junits Change-Id: Id6fbcba2c5f5e11bfad2c7dccf6c06f777756a47 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-16ChefAdapterImpl- checkInfo junitsTomasz Gwozdecki1-1/+44
-Added junit tests for checkInfo method to verify if input params are present -Support for Michal Kabaj as part of APPC-437 Change-Id: I29758f29f32354439ea0471e1afa3df6bb8184b9 Issue-ID: APPC-437 Signed-off-by: Tomasz Gwozdecki <tomasz.gwozdecki@nokia.com>
2018-03-15Add Junit for ConnectionDetails classNeha Sood1-0/+47
Change-Id: Ie0c7348583d6e99397374602c0b2cb804cda8d85 Issue-ID: APPC-734 Signed-off-by: Neha Sood <ns189k@att.com>
2018-03-14Unit test for SshConnectionDetails.javaPatrick Brady2-42/+110
Unit test for SshConnectionDetails.java Sonar Link: https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-ssh-adapter-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fssh%2FSshConnectionDetails.java Change-Id: I0be7e83bac3be615a664f3c1089dae299c8d3858 Issue-ID: APPC-715 Signed-off-by: amshegokar <AS00500801@techmahindra.com> Signed-off-by: Patrick Brady <pb071s@att.com>
2018-03-13Coverage for org.onap.appc.adapter.ssh classesamshegokar3-14/+168
Coverage for org.onap.appc.adapter.ssh classes Sonar-Link: https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-ssh-adapter-tests%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fssh Change-Id: Icd1dde27c8588f217b6cca83f1cde3a8b24a41c3 Issue-ID: APPC-725 Signed-off-by: amshegokar<AS00500801@techmahindra.com>
2018-03-13ChefAdapterImpl JunitsMichal Kabaj5-170/+85
-Added new Unit tests for ChefAdapterImpl#trigger method -Refactored ChefAdapterFactory to allow mock injection -Added new create() method to ChefApiClientFactory which does not set any Chef specific headers for the purpose of trigger method -Cleaned up the trigger method - simplified usage, removed useless doFailure method and inlined its logic and unified HttClient usage -> HttpClient is not used directly but through existing ChefApiClient -removed redundant TestChefAdapterImpl tests which have already been rewritten Change-Id: I830d203877224aa2c5e1b0dff39d1171f1f2f0ef Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-12Decouple ChefApiClientImpl from header creationMichal Kabaj4-21/+42
Introduce new FunctionalInterface HttpHeaderFactory to allow customization of http header providers when creating ChefApiClientImpl using ChefApiClientFactory This allows for better encapsulation of header specific values such as: userId,organizations,pemPath. Change-Id: Iec2c7cff8e664a18e15d7e973920152fdb158c98 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-09ChefAdapterImpl JUnitsMichal Kabaj10-36/+316
-Added unit tests for chefXXX methods - extracted new test class -Moved privateKeyCheck method to new class PrivateKeyChecker + JUnits -New Factory class ChefAdapterFactory for ChefAdapterImpl construction -Fixed potential bug with wrong String being assigned in iniSvcLogic method Change-Id: I27badfd01bfaa807b8ecb9b4a4c13e7f026e34af Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-08upgrade bcprov to 1.56Taka Cho2-4/+4
there are two versions: 1.55 and 1.47 to be upgraded to 1.56 Change-Id: Ib12c5798e4a53b2c75be448f0e855d61bf168a38 Issue-ID: APPC-708 Signed-off-by: Taka Cho <tc012c@att.com>
2018-03-08upgrade httpclient from 4.5.1 to 4.5.3Taka Cho4-4/+4
Change-Id: I951cc53b6f319bdb9eba25ecdeaffaae5702fbc2 Issue-ID: APPC-703 Signed-off-by: Taka Cho <tc012c@att.com>
2018-03-06ChefAdapterImpl JUnitsMichal Kabaj3-9/+103
-Added unit testcases for retrieveData method - extracted new test class -Added unit test for combineStrings method Change-Id: I8adcc9d2dc17e4ebf305fc2a8139095d5841a445 Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-06upgrade httpclient from 4.5.2 to 4.5.3Taka Cho1-1/+1
Change-Id: I2cd2eb825a22c48807464d7f7185788fde975981 Issue-ID: APPC-689 Signed-off-by: Taka Cho <tc012c@att.com>
2018-03-05Unit Test Coverage Part:2amshegokar5-0/+306
Unit Test Coverage for: 1. Snapshot.java 2. Volume.java 3. Volume_.java 4. Template.java 5. SnapshotRestoreResponse.java Sonar Link: https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-iaas-adapter-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fopenstack%2Fheat%2Fmodel Change-Id: I18ecc259973bbd3934f9ccd4cc20d897444d9d76 Issue-ID: APPC-686 Signed-off-by: amshegokar <AS00500801@techmahindra.com>
2018-03-01security issue jackson-mapper 1.9.12Taka Cho6-6/+6
Change-Id: I89266f7a8dde8bc409f4edc8bdf91195c4249515 Issue-ID: APPC-675 Signed-off-by: Taka Cho <tc012c@att.com>
2018-03-01Unit test Coverageshubhada2-0/+125
Unit Test Coverage for: 1. EventHeader.java 2. EventStatus.java Sonar Link: https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-message-adapter-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fmessage%2Fevent Change-Id: I6b48fa3ac5af489b24d212ca52bdc1a51b388dbc Issue-ID: APPC-680 Signed-off-by: shubhada <SV00449682@techmahindra.com>
2018-03-01Unit Test Coverageshubhada4-0/+223
Unit Test Coverage for: 1. Data.java 2. CreateSnapshotParams.java 3. Properties.java 4. ResourceData.java Sonar Link: https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-iaas-adapter-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fopenstack%2Fheat%2Fmodel Change-Id: I0eeef6216f536483c6b7a45d0847688d6d84fd2f Issue-ID: APPC-685 Signed-off-by: shubhada <SV00449682@techmahindra.com>
2018-03-01ChefAdapterImpl JUnitsMichal Kabaj4-37/+89
-Added new ChefAdapterImplTest class for new ChefAdapterImpl JUnits -Added test for nodeObjectBuilder method - JSON Format is now verified using JSONObject -Unified ChefAdapterImpl construction - removed unused constructors Change-Id: I63f96bac0129b5f13d34efd3a173784e0b1d8a5d Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-03-01Fixes in "appc-dmaap-adapter-bundle"wejs9-119/+578
Correction of Sonar and CheckStyle issues Added JUnit test coverage. Change-Id: I119c7555e33e09c87b572ff0b63f55e2884be75f Issue-ID: APPC-646 Signed-off-by: wejs <maciej.wejs@nokia.com>
2018-02-28Code fix for attach and detach volumesPatrick Brady2-78/+84
Cherry-picked to split up commit https://gerrit.onap.org/r/#/c/31149/ into individual jira tickets. open stack consumes cdp-pal openstack jars to connect to cinder, this fix retrives set of volumes from volumeservice provider and performs attach or detach through compute service. Change-Id: I59bce60d9f79ba9285f284fe1f56945e63d0bcba Signed-off-by: Patrick Brady <pb071s@att.com> Signed-off-by: kusuma kumari M <km583p@att.com> Issue-ID: APPC-448
2018-02-23ChefApiClient Package Reorganization and cleanupMichal Kabaj17-358/+44
-Reorganize ChefApiClient classes according to their usage, construction and implementation. -Introduce api and impl packages. -Extract interface from ChefApiClient impl -Remove unused old chefapi.* classes Change-Id: Ic1ddbdcfd0e1bbc0830b923da5aac5b68ac44a2f Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-02-21Update license text part 3Skip Wonnell1-1/+22
Issue-ID: APPC-637 Change-Id: I361c457acd27099294365f8ee3aeb167cd7fcafd Signed-off-by: Skip Wonnell <skip@att.com>
2018-02-20Update .gitignore with license textSkip Wonnell25-40/+405
Update .gitignore with license text Remove IDE generated files from repository Update .gitignore to ignore IDE Generated files Issue-ID: APPC-637 Change-Id: Ie650e2c6d46d55d06dcc54877533cb3e14be66d6 Signed-off-by: Skip Wonnell <skip@att.com>
2018-02-20Update .properties and .xml files with licenseSkip Wonnell1-0/+21
Change-Id: I551f9e9033de2f13028f28ad434003d61102d54f Issue-ID: APPC-637 Signed-off-by: Skip Wonnell <skip@att.com>
2018-02-19Unit Test for ansibleActivatorTaka4-194/+291
Change-Id: I56279239cdae934116e4d3ac8d257f593e641064 Issue-ID: APPC-600 Signed-off-by: Taka <tc012c@att.com>
2018-02-19ChefApiClient JUnitsMichal Kabaj11-221/+747
Add(fix) JUnits for ChefApiClient + refactor. Junits work on mocked HttpClient instead of attempting to make real calls. All ChefApiClient methods are now tested. Improve readability and refactored the ChefApiClient flow (simplified). Heavily improved SRP in both ChefApiClient and Api request creation. Change-Id: I997490bf269e7d78b741baf7f8d5d7bf64f6b99a Issue-ID: APPC-437 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-02-18refactor LookupServer for nesting tryTaka1-37/+43
Change-Id: Id27025cd6d4f5a4f8ba9653b656d263585edb24e Issue-ID: APPC-599 Signed-off-by: Taka <tc012c@att.com>
2018-02-18Sonar fixes in "appc-dmaap-adapter-bundle"wejs2-137/+141
Also CheckStyle fixes. No major refactoring. Change-Id: Icf5e7221ecee2611f77bb3212c24d1fad9a27b96 Issue-ID: APPC-646 Signed-off-by: wejs <maciej.wejs@nokia.com>
2018-02-18refactor EvacuateServer for nesting tryTaka1-109/+132
Change-Id: I4b114e6f2f41c755cf7e346a120e50441a1209dd Signed-off-by: Taka <tc012c@att.com> Issue-ID: APPC-598
2018-02-18refactor CreateSnapshot for nesting tryTaka1-39/+44
Change-Id: Ia66842fe6b680fd5f6eb74e8ddebf09f89c6c1d0 Signed-off-by: Taka <tc012c@att.com> Issue-ID: APPC-597
2018-02-16Junit Test for dmaap adapterTaka1-6/+3
Change-Id: I2dbe1375a23fcbd5e2974f9d112a162d4fbea328 Issue-ID: APPC-626 Signed-off-by: Taka <tc012c@att.com>
2018-02-14UnitTest for Rest Healthcheck activatorTaka3-204/+318
Change-Id: I214f14cc0dbc735d87bcbf5b59cf286d41dc826b Issue-ID: APPC-624 Signed-off-by: Taka <tc012c@att.com>
2018-02-14Unit test for iaas provider activatorTaka2-2/+114
Change-Id: I7e7ec6d977625406b9d4dee19d974492e1a5f4cc Issue-ID: APPC-615 Signed-off-by: Taka <tc012c@att.com>
2018-02-14refactor AnsibleMessageParser for nesting tryTaka1-57/+58
Change-Id: Idd86134a034d5f49baff34fd0d056820f45e1121 Issue-ID: APPC-596 Signed-off-by: Taka <tc012c@att.com>
2018-02-12ProviderServerOperation sonar fixesJakub Dudycz1-131/+84
Change-Id: I95cb0512c83f8d3dd94aac8f635538518ee88024 Issue-ID: APPC-604 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-12ProviderOperation sonar fixesJakub Dudycz3-95/+98
Change-Id: Ic51bf15bcf469fc105c7cd4fe9e5e538200d49b1 Issue-ID: APPC-603 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-09ChefAdapterImpl sonar fixesJakub Dudycz2-70/+70
Change-Id: I3e1a496e18a4b9e6e9dc954bc16fb4af991fd5d3 Issue-ID: APPC-579 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
2018-02-07Change url being used in chef testPatrick Brady1-1/+1
The domain that was being used for the chef test was a real url. The test failed most of the time. Setting it to localhost. Change-Id: I7c162b313b78e174ca3845920dfa88a7004983d5 Signed-off-by: Patrick Brady <pb071s@att.com> Issue-ID: APPC-556
2018-02-07ServiceCatalogV3 fixesJakub Dudycz1-53/+58
Change-Id: I28d22a5d6206b4e4aaed3a017b4db39d0d5f0709 Issue-ID: APPC-549 Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>