aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-02-26Fix unit tests for PrecheckOptionJoss Armstrong1-8/+25
Increased line coverage to 100% Increased branch coverage to clear Sonar major warning Removed console logging and cleaned up assertions Issue-ID: APPC-1499 Change-Id: Ifc7163d2e112914749514099779bd5d75ba729c9 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Fixed tests on PreCheck classJoss Armstrong1-10/+23
Replaced console printing with assertions Added branch coverage to clear Sonar major warning Increased line coverage to 100% Issue-ID: APPC-1499 Change-Id: Ia027b9d7f414789816d80e12543d27a0baeed9c1 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Fix for timeout error when logging >1MB dataJoss Armstrong6-11/+123
Potentially large logs moved to TRACE level, INFO level logs limited in size and related tests updated Issue-ID: APPC-1489 Change-Id: I9ea85e64380479d835da03ed2af3e4ab96ece67e Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Added test case for Attach volume classLathishbabu Ganesan1-2/+18
Issue-ID: APPC-1467 Change-Id: Ifc902979c955df03ab847b4dd770bf737ff69eb9 Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
2019-02-26Added test case for Appc ProviderLathishbabu Ganesan1-0/+124
Increased the coverage from 0% to 96% Issue-ID: APPC-1454 Change-Id: I5bfb97101dd7ef5e9c138694b783be8cdd511f0e Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
2019-02-26Fix for casting/subclassing in MetricRegistryJoss Armstrong2-11/+40
Put in code to avoid cast exceptions from this class and updated tests Issue-ID: APPC-1480 Change-Id: I8b54d93e52eb523f08d13e874b4d18d05feede6b Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Test coverage for CCAActivatorJoss Armstrong4-7/+153
Increased coverage from 0% to 93% Issue-ID: APPC-1497 Change-Id: Ie78ac50a08b47cac9bedb9d34b089ac3ad23ab22 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Handled interrupted exception RecheckedJegadeesh Babu1-0/+3
Rechecked sonar fix Issue-ID: APPC-1492 Change-Id: I8cec7e0e0cb5614e959f6eaa35271f55ddbba24b Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-26Added logger statementJegadeesh Babu1-1/+6
Sonar vulnerabilty fix Issue-ID: APPC-1498 Change-Id: I29de3443a5a96c4d4bc5c7bab24b4fdb7f3358d3 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-26Test coverage for ParametersJoss Armstrong1-1/+14
Increased coverage to 100% Issue-ID: APPC-1499 Change-Id: I982023d9f818320f709da552d668b68e5ce0f7b3 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Test coverage for ActionIdentifierJoss Armstrong1-6/+17
Increased test coverage to 100% Issue-ID: APPC-1499 Change-Id: I78eee1fdc64840898e1b76984855a43828ee93b4 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-26Update GetDevRunningConfig for SaltstackDGGanesh Chandrasekaran1-496/+876
Issue-ID: APPC-1101 Change-Id: Ie3cbfb05b1dd7a1ecc15e0d7b844801769836fab Signed-off-by: Ganesh Chandrasekaran <ganesh.c@samsung.com>
2019-02-26APPC Generic Saltstack DG additionGanesh Chandrasekaran1-0/+491
Issue-ID: APPC-1101 Change-Id: Ie240bb949481a7c59a508c2157a4ace95fe4a861 Signed-off-by: Ganesh Chandrasekaran <ganesh.c@samsung.com>
2019-02-25Changes for new odl versionPatrick Brady64-3208/+277
Changes required to update to latest opendaylight version. Some powermock tests have been temporarily removed due to an powermock incompatibility. They will be fixed and re-added. Change-Id: I418d44913fcd42423d2d9bd37b189f6301eaab81 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1370
2019-02-25Test coverage in RequestValidatorImplJoss Armstrong2-26/+51
Increased coverage from 78% to 89% Issue-ID: APPC-1485 Change-Id: I2b4e87d0ae9b344ef59005bc19cd2600e4e041e8 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-22Test coverage in ExecuteNodeActionImplJoss Armstrong2-8/+62
Increase coverage from 42% to 92% Issue-ID: APPC-1477 Change-Id: Ic9ef407663d0a79ccec8ed7045230c4d734a3cc4 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-22Test coverage in MetricRegistryImplJoss Armstrong2-11/+65
Added test coverage for MetricRegistryImpl Issue-ID: APPC-1478 Change-Id: I91eff5418ec14d294fa80af3d6d7025338b82072 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-22Test coverage in MessageAdapterImplJoss Armstrong2-11/+113
Added test cases for untested portions of code Issue-ID: APPC-1481 Change-Id: Id61ec5c5824c3d9fecbfb83d47bfa0164ae96759 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-22Test coverage in AbstractRequestHandlerImplJoss Armstrong1-8/+64
Increased coverage from 72% to 95% Issue-ID: APPC-1484 Change-Id: I1bbb8aaf1b7ca33b20d8768cacd14c7bdabe5caa Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-22Test coverage for RequestValidationPolicyJoss Armstrong2-7/+90
Added test cases for untested parts of code Issue-ID: APPC-1482 Change-Id: I3dfa64b4eb1f69a08ca3346d75ae362affd55e0d Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-22Error in ScheduledPublishingPolicyImplJoss Armstrong2-38/+57
Fix for error in code that causes failure in a particular case Issue-ID: APPC-1479 Change-Id: If9f8dc21d151ea3e06939ad4db4272f48a8e8b58 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-22Resolved merge conflictJegadeesh Babu1-0/+5
Resolved conflict Issue-ID: APPC-1474 Change-Id: I2c46a69b112aa3b3796fcb2939b34a8c604e5119 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-22Seperated assignment statement from expressionJegadeesh Babu1-1/+4
Sonar bug fix Issue-ID: APPC-1468 Change-Id: I2ff7e01516cf7328357d2a48643947c782ce4fd9 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-21Change dg-mdsal to blueprintPatrick Brady6-322/+45
Change-Id: I8f9978dce4e7f483a35a338f8c57b854a7c5b29e Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1368
2019-02-21Change appc-oam to blueprintPatrick Brady10-366/+50
Change-Id: I848953fd492ad05d178c7b2d85b191248b45fa36 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1368
2019-02-21Change seq generator to blueprintPatrick Brady10-358/+28
Change-Id: Ib46f149f3c4f7b838beb58f75bc20269ac945a3a Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1368
2019-02-21Remove duplicate versionsPatrick Brady10-27/+10
These versions are inherited from opendaylight parent poms. Removing the override for these inherited versions. Change-Id: I83b374e4d8815e21fd48bedbe4dd46bc246e44a4 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1355
2019-02-21Sonar Fixes - ProviderStackOperation.javaDriptaroop Das1-2/+6
Sonar Fixes - ProviderStackOperation.java Issue-ID: APPC-1461 Change-Id: I31aef2c7328f1c3970e18a30530a9848bd5b6466 Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
2019-02-21Test coverage in LogPublisherJoss Armstrong2-1/+42
Added 100% coverage for LogPublisher Issue-ID: APPC-1478 Change-Id: Iaf1d10826eb7cd622f63bf0a7de0b2420bb8f597 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-21Increase coverage of Passwords from 42% to 98%Joss Armstrong2-17/+75
Also fixed some issues around null values and logging Issue-ID: APPC-1476 Change-Id: I0145b5c973fe9a624962744ff56fd691114779ba Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-21Test coverage for HttpClientUtilJoss Armstrong2-1/+41
Add new test class and increase coverage Issue-ID: APPC-1462 Change-Id: Ie0de18d9c22c3913c5b57bc1f2de2e8758c26ed0 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-21Added test case for Configuration classLathishbabu Ganesan2-7/+46
Issue-ID: APPC-1449 Change-Id: I84bb511d121e3af1426d4422ad3ce520bb5fd29c Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
2019-02-21Test coverage in MapperJoss Armstrong2-3/+32
Increased coverage to 98% Issue-ID: APPC-1462 Change-Id: Ie6aa2dc885be4ede947c3f7856f93cf9f1efffa0 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-21Test coverage in LCM ProviderOperationsJoss Armstrong3-4/+38
Added test cases Issue-ID: APPC-1462 Change-Id: I577bcbb1f1ea36fdddbe30b115710588472bd45c Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-21Removed prinstackTraceJegadeesh Babu1-2/+2
Sonar fix Issue-ID: APPC-1475 Change-Id: I0330868328589dded0db6afa7ae2fe75f0b6ada0 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-21Test coverage in OutgoingMessageJoss Armstrong2-93/+191
Increased coverage to 100% Issue-ID: APPC-1462 Change-Id: I4b2646da01c20e9095c617d1f82c78fae30f2418 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-21Handled interrupted ExceptionJegadeesh Babu1-0/+3
Sonar Bug Fix Issue-ID: APPC-1469 Change-Id: I3f1fe6b620e8b01659e1b927b1f5fb667be20648 Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
2019-02-21Sonar Fix : CoreManager.javaSudarshan Kumar1-1/+1
Sonar Fix CoreManager.java - Removed printStackTrace Issue-ID: APPC-1399 Change-Id: Id24936f8c41966e6f6c09348d762ba40487682da Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-02-21Sonar Fix : Time.javaSudarshan Kumar1-2/+4
Sonar Fix : Time.java - Removed printStackTrace Issue-ID: APPC-1399 Change-Id: Icc39933cf656ffd79917596ce686f09b8c638843 Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-02-20Added test case for Appc Provider clientLathishbabu Ganesan1-0/+54
Increased the coverage from 0% to 100% Issue-ID: APPC-1455 Change-Id: I0e719bd084a985b63110f15681b6a87ec4affb4d Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>
2019-02-20Vulnerabilities Fix - XResponseProcessor.javaSudarshan Kumar1-3/+6
Removed printStacktrace and specified specific exception Issue-ID: APPC-1399 Change-Id: I44c938cdd00a88ff76dfa36dbe49942f91546bb2 Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-02-20Sonar Fix: Removed printStacktraceSudarshan Kumar1-3/+5
Sonar Fix: Removed printStacktrace Issue-ID: APPC-1399 Change-Id: I0d33fac270a2082cc7b284c2df8e47fbf5b139a9 Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-02-20Sonar Fixes - AAIResourceNode.javaDriptaroop Das1-12/+7
Sonar Fixes - AAIResourceNode.java Issue-ID: APPC-1459 Change-Id: I19dd99bfc59feaf27b090440b6c1ff03d7fe16c0 Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
2019-02-19Added test case for TestSshAdapterMock.javaSudarshan Kumar1-1/+13
Added additional test case for TestSshAdapterMock.java Issue-ID: APPC-1372 Change-Id: Ib2b6051cb8a47cc133b378d4fed6de326d37c4e5 Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
2019-02-19Test coverage in EventHandlerImplJoss Armstrong2-7/+42
Added test cases for untested code Issue-ID: APPC-1462 Change-Id: I492721a9c40678bb8700d30782cfa5949c1f22e9 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-19Increase coverage in ControllerImplJoss Armstrong2-3/+67
Coverage increased to 94% Issue-ID: APPC-1462 Change-Id: I7e3af44d7627db7d09069c402e5aa47f518fd490 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-19Correct line indent spacingPatrick Brady2-150/+150
The indent spacing was incorrectly changed to 2 spaces instead of 4 by https://gerrit.onap.org/r/#/c/78396/ The incorrect spacing change was causing merge conflicts in another commit. Change-Id: I6693b3bfaa5685318c8ada5d7984235c788b9504 Signed-off-by: Patrick Brady <patrick.brady@att.com> Issue-ID: APPC-1420
2019-02-19Fix code error in ControllerImpl classJoss Armstrong1-1/+3
Put in correct check for null ListenerClass attribute Issue-ID: APPC-1463 Change-Id: I55cd4327f4718c320e3feaf71db7ac23f59a0986 Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-19Test coverage for CommonMessageJoss Armstrong2-36/+60
Increased coverage from 41% to 95% Issue-ID: APPC-1462 Change-Id: I602a0178617f29ab34f7a4ab4400d6e5c442bd9d Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
2019-02-18Added test case for OutputMessage PluginLathishbabu Ganesan1-0/+57
Increased the code coverage from 0% to 100% Issue-ID: APPC-1431 Change-Id: Ic05b358428745698d0b4871b9c6213c9c8130c7c Signed-off-by: Lathishbabu Ganesan <lathishbabu.ganesan@ericsson.com>