diff options
author | Jakub Dudycz <jakub.dudycz@nokia.com> | 2018-02-26 12:38:53 +0100 |
---|---|---|
committer | Patrick Brady <pb071s@att.com> | 2018-02-26 19:11:11 +0000 |
commit | 312e9f071ef0a8b3482278e8909f66f4c986ba89 (patch) | |
tree | 8aecf342768b9d86fb1f68bf107ef5c313b2c7f8 /appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/ConfigGeneratorActivator.java | |
parent | 534f94b92547efab097040209e61fa06e07f6e43 (diff) |
appc-config-generator-provider sonar fixes part 2
Sonar fixes in whole module
Change-Id: I55856a6ce73a73098dadb2c5b9428437349ed8a8
Issue-ID: APPC-671
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Diffstat (limited to 'appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/ConfigGeneratorActivator.java')
-rw-r--r-- | appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/ConfigGeneratorActivator.java | 28 |
1 files changed, 13 insertions, 15 deletions
diff --git a/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/ConfigGeneratorActivator.java b/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/ConfigGeneratorActivator.java index 957f324d3..1dfd4c1d3 100644 --- a/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/ConfigGeneratorActivator.java +++ b/appc-config/appc-config-generator/provider/src/main/java/org/onap/sdnc/config/generator/ConfigGeneratorActivator.java @@ -39,8 +39,9 @@ import org.osgi.framework.ServiceRegistration; public class ConfigGeneratorActivator implements BundleActivator { - private List<ServiceRegistration> registrations = new LinkedList<ServiceRegistration>(); - + private static final String STR_REGISTERING_SERVICE = "Registering service "; + private static final String STR_REGISTERING_SERVICE_SUCCESS = "Registering service successful for "; + private List<ServiceRegistration> registrations = new LinkedList<>(); private static final EELFLogger log = EELFManager.getInstance().getLogger(ConfigGeneratorActivator.class); @@ -49,29 +50,29 @@ public class ConfigGeneratorActivator implements BundleActivator { public void start(BundleContext ctx) throws Exception { ConvertNode convertNode = new ConvertNode(); - log.info("Registering service " + convertNode.getClass().getName()); + log.info(STR_REGISTERING_SERVICE + convertNode.getClass().getName()); registrations.add(ctx.registerService(convertNode.getClass().getName(), convertNode, null)); - log.info("Registering service sccessful for " + convertNode.getClass().getName()); + log.info(STR_REGISTERING_SERVICE_SUCCESS + convertNode.getClass().getName()); MergeNode mergeNode = new MergeNode(); - log.info("Registering service " + mergeNode.getClass().getName()); + log.info(STR_REGISTERING_SERVICE + mergeNode.getClass().getName()); registrations.add(ctx.registerService(mergeNode.getClass().getName(), mergeNode, null)); - log.info("Registering service sccessful for " + mergeNode.getClass().getName()); + log.info(STR_REGISTERING_SERVICE_SUCCESS + mergeNode.getClass().getName()); PatternNode patternNode = new PatternNode(); - log.info("Registering service " + patternNode.getClass().getName()); + log.info(STR_REGISTERING_SERVICE + patternNode.getClass().getName()); registrations.add(ctx.registerService(patternNode.getClass().getName(), patternNode, null)); - log.info("Registering service sccessful for " + patternNode.getClass().getName()); + log.info(STR_REGISTERING_SERVICE_SUCCESS + patternNode.getClass().getName()); ReaderNode readerNode = new ReaderNode(); - log.info("Registering service " + readerNode.getClass().getName()); + log.info(STR_REGISTERING_SERVICE + readerNode.getClass().getName()); registrations.add(ctx.registerService(readerNode.getClass().getName(), readerNode, null)); - log.info("Registering service sccessful for " + readerNode.getClass().getName()); + log.info(STR_REGISTERING_SERVICE_SUCCESS + readerNode.getClass().getName()); FileWriterNode writerNode = new FileWriterNode(); - log.info("Registering service " + writerNode.getClass().getName()); + log.info(STR_REGISTERING_SERVICE + writerNode.getClass().getName()); registrations.add(ctx.registerService(writerNode.getClass().getName(), writerNode, null)); - log.info("Registering service sccessful for " + writerNode.getClass().getName()); + log.info(STR_REGISTERING_SERVICE_SUCCESS + writerNode.getClass().getName()); } @@ -79,9 +80,6 @@ public class ConfigGeneratorActivator implements BundleActivator { public void stop(BundleContext arg0) throws Exception { for (ServiceRegistration registration : registrations) { registration.unregister(); - registration = null; } - } - } |