From 0141df20b1f533cd2acabdf7ea986aebab8d6868 Mon Sep 17 00:00:00 2001 From: Patrick Brady Date: Tue, 24 Mar 2020 15:44:15 -0700 Subject: Authentication support for cdt -Adding a password box to cdt -Adding a function to check login by making a request to appc -Moving username and authentication to session storage from localstorage so that it is not saved in the browser -Removing the hardcoded credentials from the cdt proxy since these are coming from the cdt login form now Change-Id: I8bd829a22d1b83829c1d53637dc1ad035d1030e9 Signed-off-by: Patrick Brady Issue-ID: APPC-1854 --- src/app/vnfs/LoginGuardService/Login-guard-service.ts | 6 +++--- src/app/vnfs/LoginGuardService/LoginGuardService.spec.ts | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'src/app/vnfs/LoginGuardService') diff --git a/src/app/vnfs/LoginGuardService/Login-guard-service.ts b/src/app/vnfs/LoginGuardService/Login-guard-service.ts index 1e7e752..1938030 100644 --- a/src/app/vnfs/LoginGuardService/Login-guard-service.ts +++ b/src/app/vnfs/LoginGuardService/Login-guard-service.ts @@ -1,7 +1,7 @@ /* ============LICENSE_START========================================== =================================================================== -Copyright (C) 2018 AT&T Intellectual Property. All rights reserved. +Copyright (C) 2018-2020 AT&T Intellectual Property. All rights reserved. Copyright (C) 2018 IBM. =================================================================== @@ -35,7 +35,7 @@ export class LoginGuardService implements CanActivate { canActivate(route: ActivatedRouteSnapshot, state: RouterStateSnapshot): boolean { - let userId = localStorage['userId']; + let userId = sessionStorage['userId']; if (userId != null && userId != undefined && userId != '') { return true; } else { @@ -44,4 +44,4 @@ export class LoginGuardService implements CanActivate { } } -} \ No newline at end of file +} diff --git a/src/app/vnfs/LoginGuardService/LoginGuardService.spec.ts b/src/app/vnfs/LoginGuardService/LoginGuardService.spec.ts index 1c57478..a2e26b8 100644 --- a/src/app/vnfs/LoginGuardService/LoginGuardService.spec.ts +++ b/src/app/vnfs/LoginGuardService/LoginGuardService.spec.ts @@ -51,14 +51,14 @@ describe('LogginGuard', () => { }); it('be able to hit route when user is logged in', inject([LoginGuardService], (service: LoginGuardService) => { - localStorage['userId'] = 'abc@xyz.com'; + sessionStorage['userId'] = 'abc@xyz.com'; let route : ActivatedRouteSnapshot; let state: RouterStateSnapshot; expect(service.canActivate(route, state)).toBe(true); })); it('be able to navigate to login page when user is not logged in', inject([LoginGuardService], (service: LoginGuardService) => { - localStorage['userId'] = ''; + sessionStorage['userId'] = ''; let route : ActivatedRouteSnapshot; let mockSnapshot:any = jasmine.createSpyObj("RouterStateSnapshot", ['toString']); expect(service.canActivate(route, mockSnapshot)).toBe(false); -- cgit 1.2.3-korg