From e612377163e148280503ca8db93223ab1fdee4dc Mon Sep 17 00:00:00 2001 From: IanHowell Date: Tue, 3 Apr 2018 15:26:47 -0500 Subject: Fix the remaining failing tests in Cadi Change-Id: Icac61b413bdc2de9ee73c14a785d26a3fe443fe4 Signed-off-by: IanHowell Modify deprecated sonar properties in AAF Modified Misc pom files. Issue-ID: AAF-208 Change-Id: Iaf4e12c81f98fdca18992ffb24b78cd0135996df Signed-off-by: Sai Gandham Include Cadi and Misc JUnits for testing phase Issue-ID: AAF-128 Change-Id: Iee531d58c3aad1c5504e2e2619f611f30063e601 Signed-off-by: IanHowell Fix a concurrency bug when removing invalid items from a Pool Change-Id: I5f3e18ff4e3eaedc2b4f3a4be1891c5187ab261b Signed-off-by: IanHowell --- cadi/core/src/main/java/org/onap/aaf/cadi/util/Pool.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'cadi/core/src/main') diff --git a/cadi/core/src/main/java/org/onap/aaf/cadi/util/Pool.java b/cadi/core/src/main/java/org/onap/aaf/cadi/util/Pool.java index d61aee21..4312c3ca 100644 --- a/cadi/core/src/main/java/org/onap/aaf/cadi/util/Pool.java +++ b/cadi/core/src/main/java/org/onap/aaf/cadi/util/Pool.java @@ -27,6 +27,7 @@ */ package org.onap.aaf.cadi.util; +import java.util.Iterator; import java.util.LinkedList; import org.onap.aaf.cadi.CadiException; @@ -210,11 +211,12 @@ public class Pool { public boolean validate() { boolean rv = true; synchronized (list) { - for (Pooled t : list) { + for (Iterator> iter = list.iterator(); iter.hasNext();) { + Pooled t = iter.next(); if (!creator.isValid(t.content)) { rv = false; t.toss(); - list.remove(t); + iter.remove(); } } } -- cgit 1.2.3-korg