From 6b4fe7bc4517171f669fa990023acf8425656235 Mon Sep 17 00:00:00 2001 From: Bharat saraswal Date: Thu, 7 Sep 2017 20:17:57 +0530 Subject: Fix sonar dcae issues Issue-Id:DCAEGEN2-94 Change-Id: I1bae3647dcaca134d1698a3e9987ca9802587e17 Signed-off-by: Bharat saraswal --- .../org/openecomp/dcae/apod/analytics/common/AnalyticsConstants.java | 4 ++++ .../openecomp/dcae/apod/analytics/common/CDAPComponentsConstants.java | 4 ++++ .../openecomp/dcae/apod/analytics/common/CDAPMetricsConstants.java | 4 ++++ .../dcae/apod/analytics/common/cdap/settings/CDAPBaseAppConfig.java | 2 ++ 4 files changed, 14 insertions(+) diff --git a/dcae-analytics-common/src/main/java/org/openecomp/dcae/apod/analytics/common/AnalyticsConstants.java b/dcae-analytics-common/src/main/java/org/openecomp/dcae/apod/analytics/common/AnalyticsConstants.java index 4294d6a..c12fa39 100644 --- a/dcae-analytics-common/src/main/java/org/openecomp/dcae/apod/analytics/common/AnalyticsConstants.java +++ b/dcae-analytics-common/src/main/java/org/openecomp/dcae/apod/analytics/common/AnalyticsConstants.java @@ -27,6 +27,10 @@ package org.openecomp.dcae.apod.analytics.common; */ public abstract class AnalyticsConstants { + //not meant to be instantiated + private AnalyticsConstants() { + } + // =============== Common Constants for all DCAE Analytics Modules ==================== // diff --git a/dcae-analytics-common/src/main/java/org/openecomp/dcae/apod/analytics/common/CDAPComponentsConstants.java b/dcae-analytics-common/src/main/java/org/openecomp/dcae/apod/analytics/common/CDAPComponentsConstants.java index ab39ee9..f830e3b 100644 --- a/dcae-analytics-common/src/main/java/org/openecomp/dcae/apod/analytics/common/CDAPComponentsConstants.java +++ b/dcae-analytics-common/src/main/java/org/openecomp/dcae/apod/analytics/common/CDAPComponentsConstants.java @@ -52,6 +52,10 @@ package org.openecomp.dcae.apod.analytics.common; */ public abstract class CDAPComponentsConstants { + //not meant to be instantiated + private CDAPComponentsConstants() { + } + // =============== Common Module Constants ==================== // /** diff --git a/dcae-analytics-common/src/main/java/org/openecomp/dcae/apod/analytics/common/CDAPMetricsConstants.java b/dcae-analytics-common/src/main/java/org/openecomp/dcae/apod/analytics/common/CDAPMetricsConstants.java index 63ac7e0..87e8b6c 100644 --- a/dcae-analytics-common/src/main/java/org/openecomp/dcae/apod/analytics/common/CDAPMetricsConstants.java +++ b/dcae-analytics-common/src/main/java/org/openecomp/dcae/apod/analytics/common/CDAPMetricsConstants.java @@ -31,6 +31,10 @@ package org.openecomp.dcae.apod.analytics.common; */ public abstract class CDAPMetricsConstants { + //not meant to be instantiated + private CDAPMetricsConstants() { + } + /** * Metric captures count of all responses received from DMaaP MR Subscriber Topic */ diff --git a/dcae-analytics-common/src/main/java/org/openecomp/dcae/apod/analytics/common/cdap/settings/CDAPBaseAppConfig.java b/dcae-analytics-common/src/main/java/org/openecomp/dcae/apod/analytics/common/cdap/settings/CDAPBaseAppConfig.java index 38c882f..9269469 100644 --- a/dcae-analytics-common/src/main/java/org/openecomp/dcae/apod/analytics/common/cdap/settings/CDAPBaseAppConfig.java +++ b/dcae-analytics-common/src/main/java/org/openecomp/dcae/apod/analytics/common/cdap/settings/CDAPBaseAppConfig.java @@ -47,6 +47,7 @@ public abstract class CDAPBaseAppConfig extends Config implements CDAPAppConfig * * @return CDAP application name */ + @Override public String getAppName() { return appName; } @@ -56,6 +57,7 @@ public abstract class CDAPBaseAppConfig extends Config implements CDAPAppConfig * * @return CDAP application description */ + @Override public String getAppDescription() { return appDescription; } -- cgit 1.2.3-korg